Repository navigation
fix(mcp): BrokenPipe 视为 stdio server 已退出 - #1144
Merged
Merged
Conversation
The EPIPE from writing stdin can arrive before try_wait or stdout EOF observe the exit, so respawn_if_exited kept the dead process. Closes #1143
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
写 stdin 的 EPIPE 可能早于 try_wait / stdout EOF 可见，respawn_if_exited 因此不重启已死进程，导致
crashing_stdio_server_is_respawned_at_most_once在 CI 上 flaky。BrokenPipe 时置 stdin_closed，ensure_running 返回错误。本地
integration_commands::mcp::tests33 项通过。Closes #1143