Skip to content

chore: add rust-coding-standard skill and symlink .claude/skills to .agents/skills - #8

Merged
setoelkahfi merged 2 commits into
chore/sigit-configfrom
chore/skills-symlink
Oct 11, 2026
Merged

setoelkahfi merged 2 commits into
chore/sigit-configfrom
chore/skills-symlink

Conversation

@setoelkahfi

Copy link
Copy Markdown
Contributor

Summary

  • .agents/skills/rust-coding-standard/SKILL.md — canonical Rust coding standard skill
  • .claude/skills is a symlink to ../.agents/skills so all agents share one source of truth

Stacks on top of #7.

…agents/skills

- .agents/skills/rust-coding-standard/SKILL.md is the canonical skill file
- .claude/skills is a symlink to ../.agents/skills

Co-Authored-By: OndeCode v1.0.1-acp <noreply@ondeinference.com>

@sigit-code-review sigit-code-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change introduces a canonical Rust coding standard for the onde crate as a skill file in .agents/skills/rust-coding-standard/SKILL.md, detailing rules for error handling, naming, async patterns, platform gating, clippy compliance, FFI, and more. It also adds a symlink .claude/skills pointing to .agents/skills, ensuring all agents share a single source of truth for skills. No code or logic is changed, only documentation and configuration for agent behavior. No earlier findings are present or need to be addressed.


Automated review by siGit Code Review · commit 7a8fc99 · see the review dashboard

@setoelkahfi
setoelkahfi added this pull request to stack #9 October 10, 2026 19:16

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is still written for Onde Inference SDK repo.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

The skill was still written for the Onde Inference SDK crate. Rewrite it to
match this repo: anyhow (no thiserror/FFI), tracing instead of log, edition
2024, mod.rs module roots, the MusicTools Toolset four-method checklist, the
deterministic exact-spelling correctness principle, and the real CI commands.

Co-Authored-By: siGit Code v1.6.6-acp <noreply@sigit.si>

@sigit-code-review sigit-code-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change introduces a canonical Rust coding standard skill for the splitfire-agent crate, detailing rules for error handling, naming, async patterns, module structure, tool conventions, deterministic music computation, logging, and clippy compliance. The skill is placed in .agents/skills/rust-coding-standard/SKILL.md. Additionally, .claude/skills is now a symlink to .agents/skills, ensuring all agents share a single source of truth for skills. The skill file is tailored for splitfire-agent, not Onde Inference SDK, as previously discussed. No code or logic is changed outside of documentation and configuration.


Automated review by siGit Code Review · commit ea5b744 · see the review dashboard

@setoelkahfi
setoelkahfi requested a review from paydii October 11, 2026 08:08
@setoelkahfi
setoelkahfi merged commit 635c341 into development Oct 11, 2026
2 checks passed
@setoelkahfi
setoelkahfi deleted the chore/skills-symlink branch October 11, 2026 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants