Repository navigation
Rename the winget package to SplitFireAI.Agent - #17
Merged
Merged
Conversation
SplitFireAI.splitfire-agent repeated the publisher in the package segment. SplitFireAI.Agent follows winget's Publisher.Product convention. Nothing is merged under the old ID, so no users are affected. The exe name, command alias, moniker and zip asset name stay as they are, since those describe the binary and not the package. The release workflow also now checks for an open "New package" PR before submitting. Until the first one merges, the folder check is always false, so each dispatch opened another PR and Package Request issue for the same package. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
siGit Code Review is paused because the linked siGit account has reached its monthly cloud allowance. On siGit Code Unlimited, reviews don't count toward it: https://sigit.si/billing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the winget package ID from
SplitFireAI.splitfire-agenttoSplitFireAI.Agent, following winget'sPublisher.Productconvention. Nothing is merged in winget-pkgs under the old ID, so the rename costs nothing for users.packaging/winget/are renamed and carry the newPackageIdentifier. The exe name,PortableCommandAlias,Monikerand zip asset name are unchanged because they describe the binary.release-winget.ymluses the new ID. Itsexistsstep now also looks for an openNew package: SplitFireAI.AgentPR and setspending=trueif it finds one. Rendering, the Package Request issue and the new-package submit are skipped when pending. This is what let two duplicate PRs and issues through before (New package: SplitFireAI.splitfire-agent version 1.2.1 microsoft/winget-pkgs#451799, #454709, #451797, #454708).Checked locally:
actionlintreports only an existing SC2129 style note on the checkout/resolve step, and the sed-rendered templates look right.winget validateneeds Windows, so that only runs in CI.After merge, I'll dispatch
release-winget.ymlwithtag=v1.2.2to open the new submission, and close the old PRs and issues as superseded.