Repository navigation
Document how embedding apps supply their own stems - #11
Merged
Merged
Conversation
Hosts decide what stems mean through a client-supplied demucs MCP server, or by returning no built-in servers from their Profile. The README and AGENTS.md now say so, and name the two result shapes the stem hooks read. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
siGit Code Review is paused because the linked siGit account has reached its monthly cloud allowance. On siGit Code Unlimited, reviews don't count toward it: https://sigit.si/billing |
Collaborator
|
Better postpone this until v1.2.0 out |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Updated README.md and .agents/AGENTS.md to document how embedding apps supply their own Demucs MCP server or handle stems differently, describing the two result shapes the stem hooks read and naming the two embedding apps that do so.
Automated review by siGit Code Review · commit 45dfa60 · see the review dashboard
Contributor
Author
|
1.2.0 is published and |
paydii
approved these changes
Oct 13, 2026
keypair34
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three apps now embed splitfire-agent and handle stems differently, and the docs only described the standalone case.
The README's stem separation section and AGENTS.md now say that an embedding app can pass its own
demucsMCP server (the SplitFire AI Audio Separator does, with its own executable in--mcpmode) or return no built-in servers from itsProfile(KaroKowe Jam and KaroKowe Karaoke do, and each writes its own guidance). They also name the two result shapes the stem hooks read:structuredContent.models[]{id,size_mb,cached}andstructuredContent.stems[].path.Since the last revision, 1.2.0 is out with the
embedfeature, andmainis merged into this branch. The new Embedding section sits next to the stems text without overlap, and Karaoke was added as the third host.Docs only, no code change.