Repository navigation
Explain embedding demucs-mcp in another binary - #8
Open
setoelkahfi wants to merge 1 commit into
Open
setoelkahfi wants to merge 1 commit into
setoelkahfi wants to merge 1 commit into
Conversation
The README covers `demucs --mcp` but not that the protocol is a separate crate behind a StemEngine trait, which is how the SplitFire AI Audio Separator serves the same tools on its own engine. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
siGit Code Review is paused because the linked siGit account has reached its monthly cloud allowance. On siGit Code Unlimited, reviews don't count toward it: https://sigit.si/billing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README describes
demucs --mcpbut not that the protocol now lives in thedemucs-mcpcrate behind aStemEnginetrait. This adds a short subsection under "Use as an MCP server": what the trait is, thatdemucs_mcp::serve(engine)runs on stdin and stdout, which checks the server makes itself (absolute, existinginput; absoluteoutput_dir), and that the engine picks the default output folder. It names the SplitFire AI Audio Separator as the second implementation.Docs only.