Repository navigation
Add script to build the Swift XCFramework - #3
Conversation
57f728c to
8de4590
Compare
![sigit-code-review[bot]](https://avatars.githubusercontent.com/in/3492899?s=60&v=4){kind=small}
There was a problem hiding this comment.
Adds build-swift-xcframework.sh (invoked via make swift-xcframework) that builds demucs-ffi as a staticlib for seven Apple targets (iOS, iOS-sim, tvOS, tvOS-sim, visionOS, visionOS-sim, macOS), generates UniFFI Swift bindings from the iOS slice, assembles a DemucsFramework.xcframework, then zips it reproducibly (fixed timestamps, sorted entries, 0o644 perms) and writes the SwiftPM checksum and crate version under dist/swift. tvOS/visionOS are tier 3 so they use +nightly -Z build-std. .gitignore adds dist/; the Makefile gains the swift-xcframework target. Reviewers should look first at the swift package compute-checksum call and the build_target invocation order.
Automated review by siGit Code Review · commit 8de4590 · see the review dashboard
.github/scripts/build-swift-xcframework.sh (make swift-xcframework) builds demucs-ffi as a static library for iOS, macOS, tvOS and visionOS, generates the Swift bindings, and packs DemucsFramework.xcframework into a reproducible zip with its SwiftPM checksum under dist/swift. tvOS and visionOS are tier 3, so they use nightly with -Z build-std. Co-Authored-By: siGit Code <noreply@sigit.si> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
8de4590 to
7427c85
Compare
.github/scripts/build-swift-xcframework.sh (make swift-xcframework)
builds demucs-ffi as a static library for iOS, macOS, tvOS and visionOS,
generates the Swift bindings, and packs DemucsFramework.xcframework into
a reproducible zip with its SwiftPM checksum under dist/swift. tvOS and
visionOS are tier 3, so they use nightly with -Z build-std.
Co-Authored-By: siGit Code noreply@sigit.si
Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com
Stack created with GitHub Stacks CLI • Give Feedback 💬