Add regression test for GH-4508 (deprecated metric names in legacy WE folders)#4514
Open
galenlynch wants to merge 3 commits intoSpikeInterface:mainfrom
Open
Add regression test for GH-4508 (deprecated metric names in legacy WE folders)#4514galenlynch wants to merge 3 commits intoSpikeInterface:mainfrom
galenlynch wants to merge 3 commits intoSpikeInterface:mainfrom
Conversation
…c names in legacy WE folders) Builds a synthetic legacy WaveformExtractor folder with deprecated quality_metrics (l_ratio, isolation_distance, qm_params) and template_metrics (peak_to_valley, peak_trough_ratio, metrics_kwargs) params, then verifies load_waveforms_backwards loads it and migrates the deprecated names before validation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
for more information, see https://pre-commit.ci
Needed to mock deprecated WaveformExtractor data
| ] | ||
|
|
||
| test_core = [ | ||
| "pandas<3", |
Member
There was a problem hiding this comment.
are we not pandas 3 compatible ??
Contributor
Author
There was a problem hiding this comment.
It's what the rest of the pyproject uses. Not sure if the version cap is needed, but kept it for consistency.
Member
There was a problem hiding this comment.
I will check this pandas3 soon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
l_ratio,isolation_distance,qm_params) and template_metrics (peak_to_valley,peak_trough_ratio,metrics_kwargs) paramsload_waveforms_backwardsloads withoutValueErrorand that deprecated names are migrated by the compat handler before validationTesting
ValueError: The metric 'peak_to_valley' has been re-named...)Addresses: #4509 (comment)