Repository navigation
[pull] main from fable-compiler:main - #273
Merged
Merged
Conversation
Co-authored-by: Mangel Maxime <me@mangelmaxime.fr>
…mparison
str.slice(-pattern.length) becomes slice(-0) === slice(0) (the whole
string) when pattern is empty, so EndsWith("") returned false for
culture/ignore-case comparisons. .NET returns true (every string ends
with ""). Use slice(str.length - pattern.length) instead.
…sky pre-commit hook)
- Dequeued messages were tested for truthiness, so 0, false, "", null and undefined (unit) messages were silently dropped; the queue now wraps dequeued values so emptiness is distinguishable - postAndAsyncReply gated completion on result !== undefined, so AsyncReplyChannel<unit> never completed and the caller hung forever; use an explicit replied flag
…antics (#4741) Co-authored-by: Mangel Maxime <me@mangelmaxime.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )