chore: Implement Coverage Evaluation on Feature Branch Against Main PQE-407#82
chore: Implement Coverage Evaluation on Feature Branch Against Main PQE-407#82ykaiboussiSO wants to merge 10 commits into
Conversation
Branch Resolves: PQE-407
WalkthroughGitHub Actions workflows are enhanced with coverage regression detection via a new reusable workflow that uploads main-branch coverage artifacts. The test job compares feature-branch coverage against main and fails if the value decreases. Integration tests are migrated to use make targets instead of direct Go commands, and action versions across workflows are pinned to specific commit SHAs for reproducibility. ChangesCI Coverage Validation and Integration Test Migration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/go-test.yml:
- Line 81: The conditional currently uses `(( echo "$current_coverage <
$main_coverage" | bc -l ))`, which is invalid; change the condition to use
command substitution so the pipeline is evaluated first, e.g. wrap the pipeline
in `$()` so the `if` becomes `if (( $(echo "$current_coverage < $main_coverage"
| bc -l) )); then`; update the `if` that references `current_coverage` and
`main_coverage` accordingly to use this form.
In @.github/workflows/upload-coverage-files.yml:
- Line 24: The workflow output mapping uses
workflow_call.outputs.coverage-artifact-id but points to the wrong job id;
update the output reference to pull from the actual job id
jobs.upload-main-coverage-files (e.g., change the value expression that
currently uses jobs.upload-coverage-files.outputs.coverage-artifact-id to
jobs.upload-main-coverage-files.outputs.coverage-artifact-id) so callers of
workflow_call can access the correct coverage-artifact-id output.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: ea70014a-6aa4-4d67-a86d-7a9f0c6e294b
📒 Files selected for processing (3)
.github/workflows/go-test.yml.github/workflows/run-static-analysis.yml.github/workflows/upload-coverage-files.yml
Description
Resolves: PQE-407
Type of Change
Testing
Verified coverage evaluation against main branch after running
make testwithin feature branchmake test_allwithCONNECTION_STRINGset)Screenshots (if appropriate):
Driver Impact
drivers/pg)drivers/neo4j)Checklist
go.mod/go.sumare up to date if dependencies changedSummary by CodeRabbit