Skip to content

chore: Remove Unneeded Creds from Build - BED-8282#200

Merged
mykeelium merged 3 commits into
mainfrom
mcuomo/BED-8282
May 19, 2026
Merged

chore: Remove Unneeded Creds from Build - BED-8282#200
mykeelium merged 3 commits into
mainfrom
mcuomo/BED-8282

Conversation

@mykeelium
Copy link
Copy Markdown
Contributor

@mykeelium mykeelium commented May 19, 2026

This change removes unnecessary Credentials that are being passed into the Dockerfile. Since they are unused, it is removed.

Summary by CodeRabbit

  • Chores
    • Updated CI/CD container build configuration to stop passing build-time secret variables during image build and push steps, while retaining existing tagging, labeling, and push behavior.

Review Change Stack

@mykeelium mykeelium self-assigned this May 19, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 04bdbb90-b919-4b00-a824-6d41138d736a

📥 Commits

Reviewing files that changed from the base of the PR and between 4335700 and ffae21e.

📒 Files selected for processing (2)
  • .github/workflows/build.yml
  • .github/workflows/publish.yml
💤 Files with no reviewable changes (2)
  • .github/workflows/build.yml
  • .github/workflows/publish.yml

Walkthrough

This PR removes GIT_AUTH_TOKEN secret credentials from Docker build steps in GitHub Actions workflows. Two workflows are updated: build.yml (removing secrets from two steps) and publish.yml (removing secrets from one step). All other build configuration, tagging, and push behavior remains intact.

Changes

CI/CD Secret Removal

Layer / File(s) Summary
Remove Docker build secrets from containerization steps
.github/workflows/build.yml, .github/workflows/publish.yml
Docker build secrets blocks that passed GIT_AUTH_TOKEN are removed from the "Build Container Image" step in build.yml, the "Push Image" step in build.yml, and the "Build Container Image" step in publish.yml. Build context, build arguments, image tags/labels, and push configuration remain unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A token hopped out of the build's bright light,
No secrets tucked in the image tonight.
Workflows now lighter, steps hum along,
Quiet and tidy, the CI sings a song.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: removing unused credentials from build workflows in GitHub Actions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mcuomo/BED-8282

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mykeelium mykeelium merged commit 1d812fb into main May 19, 2026
10 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants