Fix mb_update_arrayptr() false matches after array reallocation - #1
Open
spatial-dan wants to merge 2 commits into
Open
Fix mb_update_arrayptr() false matches after array reallocation#1spatial-dan wants to merge 2 commits into
spatial-dan wants to merge 2 commits into
Conversation
added 2 commits
August 29, 2026 00:29
Matching registered arrays by stale data pointers allowed a recycled heap address to rebind sidescan locals (sslon) to a bathymetry buffer.
Make the staged bathymetry and sidescan case deterministic by injecting a stale pointer collision before the sidescan reallocation. This directly verifies that mb_update_arrays() clears saved pointer values between reallocation cycles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent mb_update_arrayptr() from rebinding a registered array to the wrong allocation when the allocator reuses an address from an earlier reallocation cycle. The mb_update_arrayptr() matched arrays using values retained in regarray_oldptr[]. Those values could outlive their reallocation cycle. If the allocator later reused one of those addresses, a local pointer—such as a sidescan longitude array—could falsely match an earlier bathymetry registration and be rebound to the wrong buffer.
Fix
Added tests covering: