fix: correct REQ-CMP-003/REQ-LIN-008 .fusa-reqs.json citation gaps - #163
Merged
Conversation
Found during a systemic citation-drift audit modeled on c-RCP's own
issue #434 (a TC18.txt rebaseline shifted line numbers ~350-450 lines
across most of the document). The .fusa-reqs.json layer itself turned
out to be essentially clean -- only these two entries had a genuine
issue:
- REQ-CMP-003: cited TC18.txt L1434-1438 for Table 7's caption. Those
lines still correctly hold the cmp_start_state/cmp_next_state/
cmp_sequencer field descriptions the requirement is actually about
(verified directly against TC18.txt), but Table 7's own caption
('Table 7: Usage of GBB message for compound requests') now sits at
line 1458, ~20-24 lines later -- the table number itself is still
correct, only the caption's own line position drifted. Citation
updated to note both locations rather than implying they're
co-located.
- REQ-LIN-008: its second quoted citation ('It sends the bytes
provided...') had no line-number citation at all -- a completeness
gap, not drift. Confirmed the quote's real location (TC18.txt
L5691-5692) and added it.
The much larger finding from this same audit -- systemic TC18.txt
citation drift in src/*.rs doc comments across 17 files (58 of 101
checked citations, ~370-420 line drift, mirroring c-RCP's own pattern
exactly) -- is filed as a separate tracking issue rather than folded
into this small, already-fully-verified fix.
Verification: cargo build clean, api-snapshot-check.sh OK, rsfusa
check 0 errors, rsfusa trace 628/628 100% traced+tested (unchanged
counts, citation-text-only change).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Signed-off-by: Matt <47545907+SoundMatt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small, fully self-verified fix found during a systemic citation-drift audit modeled on c-RCP's own issue #434. See commit message for full detail. The .fusa-reqs.json layer is essentially clean overall — only these two entries needed a fix. The much larger finding (systemic drift in src/*.rs doc comments, 17 files affected) is being filed as a separate tracking issue, not folded into this PR.