rewrite(phase6): batch 3 — conditional-request cluster catalog re-derivation - #157
Merged
SoundMatt merged 1 commit intoAug 22, 2026
Merged
Conversation
…ivation Part of the v3.0.0 ground-up rewrite (cpp-RCP #129, ROADMAP.md Phase 17), branch rewrite/v3-from-c-rcp. Phase 6 (requirement catalog), batch 3 of 13 -- the largest single-concern batch so far. ## Scope request.hpp's conditional-request cluster: Compound (REQ-CMP-*, 29 c-RCP entries), Triggered (REQ-TRIG-*, 13), Chained (REQ-CHAIN-*, 12), Timed (REQ-TIMED-*, 13), Cancellation (REQ-CANCEL-*, 15), and the scheduler (REQ-SCHED-*, 8) -- 90 c-RCP entries total, all already orphan-cited across request.hpp/test_request.cpp. c-RCP splits this across three files (request.c/request_sequencer.c/scheduler.c); cpp-RCP's rewrite deliberately keeps its own prior unification into one file (documented cpp-RCP design choice, not re-split), while keeping c-RCP's id-prefix scheme per RELAY docs/RCP-ARCHITECTURE.md's canonical choice #7. ## New catalog entries (70) - REQ-CMP-{001-003,010-029} (23) - REQ-TRIG-{001,004-013} (11) - REQ-CHAIN-{002,004-007,010-012} (8) - REQ-TIMED-{002-011} (10) - REQ-CANCEL-{002-015} (14) - REQ-SCHED-{002,003,007,008} (4) Each verified against real request.hpp code/test_request.cpp tests, not rubber-stamped from the pre-existing orphan-tag manifest. Two new tests added (REQ-CHAIN-005, REQ-TIMED-004) that had no dedicated test before. ## Genuine gaps found (7 new, filed to .fusa-reqs-pending.json, total now 19) - REQ-CMP-008/009, REQ-TRIG-003, REQ-CHAIN-003: encode_compound_ request()/encode_triggered_request()/encode_chained_member() never validate their type/payload-size before encoding -- they forward straight to acf::encode_acf_gbb(), which by design never rejects -- and their plain std::vector<uint8_t> return type has no channel to signal rejection at all, unlike encode_timed_request()'s own std::optional<...> (confirmed: request.hpp:569/745/970 return bare std::vector, request.hpp:1077 returns std::optional -- the exact asymmetry this finding describes). No test exercised these paths. Removed the false orphan tags claiming coverage, documented the finding in-file (request.hpp:242-249). - REQ-CHAIN-008: RequestLedger::submit() never rejects a Chained request with no chained_predecessor; no CHAIN_ERROR-equivalent exists (c-RCP's rcp_chained_advance() returns RCP_CHAINED_MEMBER_CHAIN_ERROR for exactly this case, TC18 §11.2.2.6). - REQ-TIMED-012/013: no dispatch/admission entry point anywhere in cpp-RCP threads a real TSCF avtp_timestamp into timed_admit()/ timed_due() -- the primitives exist, the loop doesn't. c-RCP's own entries describe a real dispatch-layer TSCF-threading feature (rcp_mock_server_dispatch_tscf() and its E2E-aware siblings); cpp-RCP's mock.hpp has no equivalent entry point yet. Matches this file's own documented "no scheduler thread" scope -- a real, TC18-cited gap, not force-fit as implemented. ## Duplicate-coverage mappings (no new entry, no gap) CMP-004, TRIG-002, CHAIN-001, TIMED-001, CANCEL-001 -> pre-existing REQ-SEQ-009 ("RequestErrc is a distinct error category with non-empty, distinct messages") -- cpp-RCP unified all per-kind strerror requirements into one shared error category. SCHED-001 -> pre-existing REQ-SEQ-002 (category_of() already documents this classification). Note: cpp-RCP's REQ-SEQ-* is its own, pre-existing, differently-scoped prefix about this same file -- unrelated to c-RCP's request_sequencer.h REQ-SEQ-*, left untouched, out of scope. ## Judgment calls, already documented in-file (no new action) CMP-005/006/007 (peek_request_type) and SCHED-004/005/006 (frame-splitting) -- both already explicitly documented in request.hpp's own header as deliberate non-ports, composable via other already-covered functions. CHAIN-009 -- covered by RequestLedger's graph-based cascade_cancel()/propagate_chain_completion(), already documented as strictly more capable than c-RCP's positional model. ## REQ-SCHED-* prefix decision Code's own orphan tags already used REQ-SCHED-* verbatim, matching c-RCP -- kept as-is, no rename needed. ## Stale pre-existing gap entries found, not touched (out of this batch's scope) .fusa-reqs-pending.json's pre-existing REQ-SEQ-013/014/015 (filed 2026-08-07, describing missing Compound exec_delay/repetitions, Triggered trigger fields, Timed presentation_time) appear stale -- current request.hpp code genuinely implements all three (CompoundStep, TriggeredStep, TimedRequest + timed_admit()/timed_due()). Left as-is since fixing them means touching the REQ-SEQ-* prefix; flagging here for whoever picks up REQ-SEQ-* in a later batch. ## Verification Independently re-verified (not just the porting agent's own report): semantic id-keyed diff confirms zero pre-existing catalog entries modified/deleted, exactly the 70 new ids added matching the report's own breakdown per prefix exactly. Confirmed no new entry carries "severity": "cybersecurity" -- sec-tested count holds exactly at 72/544, matching the absolute-count floor fixed in batch 1. Spot- verified the encode_*_request asymmetry claim directly against request.hpp's real function signatures, and REQ-CHAIN-008/REQ-TIMED- 012/013's c-RCP source citations directly against c-RCP's own .fusa-reqs.json entries -- both check out. Full tree rebuilt from scratch: 0 errors, 0 warnings, 58/58 ctest suites pass (100%), test_request alone: 137 TEST_CASEs, 615 assertions. .fusa-reqs.json: 474 -> 544 entries (+70, 4378 -> 5203 lines). .fusa-reqs-pending.json: 12 -> 19 entries (+7, 123 -> 192 lines). include/rcp/request.hpp: 1508 -> 1537 lines. tests/test_request.cpp: 1685 -> 1717 lines. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Matt <47545907+SoundMatt@users.noreply.github.com>
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the v3.0.0 ground-up rewrite (#129, ROADMAP.md Phase 17). Phase 6 (requirement catalog), batch 3 of 13 — the largest single-concern batch so far.
This batch: Compound/Triggered/Chained/Timed/Cancellation + scheduler (90 c-RCP entries)
request.hpp's whole conditional-request cluster, unified by cpp-RCP's own prior design into one file (c-RCP splits this across 3), while keeping c-RCP's id-prefix scheme per RELAY docs/RCP-ARCHITECTURE.md's canonical choice #7.
.fusa-reqs-pending.json:encode_compound_request()/encode_triggered_request()/encode_chained_member()never validate their input and have no error-return channel at all (std::vector<uint8_t>, unlikeencode_timed_request()'sstd::optional<...>) — a real, structural asymmetry, independently spot-checked against the actual function signatures. Plus a realCHAIN_ERROR-equivalent gap and the TSCF dispatch-layer presentation-time threading c-RCP already closed but cpp-RCP's rewrite hasn't reached yet..fusa-reqs-pending.jsonentries under the unrelatedREQ-SEQ-*prefix appear stale against current code — left for whoever picks up that prefix.Verification
Independently re-verified: semantic id-keyed diff confirms zero pre-existing entries modified, exactly 70 new ids matching the agent's own per-prefix breakdown exactly. Confirmed no new entry carries
severity: cybersecurity— sec-tested count holds at the 72-entry floor. Directly spot-checked the encode-function asymmetry claim and the REQ-CHAIN-008/REQ-TIMED-012/013 c-RCP citations. Full tree rebuilt from scratch: 0 errors, 0 warnings, 58/58 ctest suites pass (test_request: 137 cases, 615 assertions).🤖 Generated with Claude Code