Skip to content

BUILD-12282: Remove obsolete Cirrus-to-GitHub migration guide - #349

Merged
matemoln merged 1 commit into
masterfrom
fix/mmolnar/BUILD-12282-markdownlintTables
Sep 16, 2026
Merged

matemoln merged 1 commit into
masterfrom
fix/mmolnar/BUILD-12282-markdownlintTables

Conversation

@matemoln

@matemoln matemoln commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

The Cirrus CI migration is complete, so this guide is no longer needed. Removing it also unblocks default-branch pre-commit run --all-files (MD060).

Summary

  • Delete .cursor/cirrus-github-migration.md
  • Drop the README and CONTRIBUTE sections that pointed at that guide

Test plan

  • pre-commit run --all-files is green
  • Pre-commit job is green on this PR
  • No remaining references to .cursor/cirrus-github-migration.md

@hashicorp-vault-sonar-prod

hashicorp-vault-sonar-prod Bot commented Sep 15, 2026

Copy link
Copy Markdown

BUILD-12282

@matemoln
matemoln marked this pull request as ready for review September 15, 2026 14:20
@matemoln
matemoln requested a review from a team as a code owner September 15, 2026 14:20
The Cirrus CI migration is complete, so drop .cursor/cirrus-github-migration.md
and the README/CONTRIBUTE sections that pointed at it. This also unblocks
default-branch pre-commit --all-files (MD060).
@matemoln matemoln changed the title BUILD-12282: Fix markdownlint table formatting in migration notes BUILD-12282: Remove obsolete Cirrus-to-GitHub migration guide Sep 15, 2026
@matemoln
matemoln force-pushed the fix/mmolnar/BUILD-12282-markdownlintTables branch from 7455001 to 9dd81ed Compare September 15, 2026 14:27
@gitar-bot

gitar-bot Bot commented Sep 15, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Fixes markdownlint table formatting in .cursor/cirrus-github-migration.md to normalize column style with compact pipes and spacing, unblocking pre-commit run --all-files. No issues found.

Review coverage

Functional validation 0 of 5 objectives covered

Rules No rules evaluated

Auto-approval Not enabled · Set up

Implementation Status ◻️ 0 of 5 objectives covered
◻️ BUILD-12282 - 0 of 5 objectives covered

This PR removes the obsolete Cirrus-to-GitHub migration guide, while the diff does not implement the pip/npm Repox routing, nodeenv configuration, workflow permissions, or README updates described in the issue.

Other objectives on this issue, possibly covered elsewhere:

  • ◻️ Route pip and npm hook installs through Repox from inside the action without nested config-pip or config-npm
  • ◻️ Ensure nodeenv continues to use https://nodejs.org/dist/
  • ◻️ Configure action IT and self-pre-commit workflows with id-token: write
  • ◻️ Ensure it-tests-repox-runner covers a sonar-xs runner
  • ◻️ Document required permissions and covered registries in the README
Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Counting what did not apply, without listing it.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud

Copy link
Copy Markdown

@matemoln
matemoln enabled auto-merge (squash) September 15, 2026 14:31
@matemoln
matemoln merged commit aad8471 into master Sep 16, 2026
19 checks passed
@matemoln
matemoln deleted the fix/mmolnar/BUILD-12282-markdownlintTables branch September 16, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants