BUILD-11805 Document BUILD_NUMBER reuse across actions wrapping get-build-number - #346
Conversation
…uild-number Audits every ci-github-actions action that internally calls get-build-number and closes the documentation gaps: - config-pip, config-poetry, config-uv: had no "Input Environment Variables" section at all despite calling get-build-number. config-poetry also needed the CURRENT_VERSION/PROJECT_VERSION reuse row, same as config-maven/config-gradle/config-npm. - build-yarn: calls get-build-number directly (no config-yarn wrapper exists) but didn't document it. - build-poetry: added a "See also config-poetry input environment variables" pointer, matching the existing build-npm/build-gradle/build-maven pattern. - promote: only documented PROJECT_VERSION, not BUILD_NUMBER. Added the row and a note that cross-job reuse (a build job followed by promote in the same workflow run, the only real-world topology - verified across every SonarSource consumer) is automatic since v2 via Git references, and qualified that mechanism as v2-only since the usage examples are pinned to the v1 branch. config-maven, config-gradle, config-npm, build-maven, build-gradle, build-npm, and get-build-number itself were already accurate and complete - no changes needed there.
d79bdd2 to
9938d00
Compare
Code Review ✅ Approved 3 resolved / 3 findingsDocuments ✅ 3 resolved✅ Quality: config-poetry env table omits CURRENT_VERSION/PROJECT_VERSION
✅ Edge Case: promote docs omit that BUILD_NUMBER is required across runs
✅ Quality: Promote example annotates @v1 with the v2-only refs mechanism
Implementation Status ✅ 4 of 4 objectives covered✅ BUILD-11805 - 4 of 4 objectives coveredThis PR covers documenting the recommended workflow pattern for BUILD_NUMBER reuse, auditing and adding BUILD_NUMBER input environment variables to actions wrapping get-build-number, cross-referencing get-build-number behavior, and adding a promote usage example. ✅ 4 covered here
OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
|



Summary
Audits every
ci-github-actionsaction that internally callsget-build-numberand closes the documentation gaps:config-pip,config-poetry,config-uv: had no "Input Environment Variables" section at all despite callingget-build-number- added it with theBUILD_NUMBERreuse row.build-yarn: callsget-build-numberdirectly (noconfig-yarnwrapper exists) but didn't document it - added the "automatically calls" note and theBUILD_NUMBERrow.build-poetry: added a "See alsoconfig-poetryinput environment variables" pointer, matching the existingbuild-npm/build-gradle/build-mavenpattern.promote: only documentedPROJECT_VERSION, notBUILD_NUMBER. Added the row and a note clarifying that cross-job reuse (e.g. abuildjob followed by apromotejob in the same workflow run) is now automatic since v2 via Git references - no manualneeds/env: BUILD_NUMBERwiring required, unlike the oldactions/cache-based v1 mechanism. Annotated the existing "Basic usage" example accordingly instead of adding a new example that would reintroduce the obsolete manual-wiring pattern.config-maven,config-gradle,config-npm,build-maven,build-gradle,build-npm, andget-build-numberitself were already accurate and complete - no changes needed there.Jira: BUILD-11805
Test plan
pre-commit run --files README.md(markdownlint + others) passesaction.ymlto confirm it actually callsget-build-number(directly or via aconfig-*wrapper) before documenting the reuse behavior