Skip to content

chore: add conventional commits guidance#1179

Closed
John-David Dalton (jdalton) wants to merge 2 commits intomainfrom
chore/conventional-commits-claudemd
Closed

chore: add conventional commits guidance#1179
John-David Dalton (jdalton) wants to merge 2 commits intomainfrom
chore/conventional-commits-claudemd

Conversation

@jdalton
Copy link
Copy Markdown
Contributor

@jdalton John-David Dalton (jdalton) commented Apr 8, 2026

Summary

  • Add conventional commits guidance to CLAUDE.md
  • Align engines to node >=18.20.8 and pnpm >=10.33.0

Note

Medium Risk
Mostly documentation and metadata changes, but tightening engines.node/engines.pnpm can break local dev/CI environments that don’t meet the new minimums.

Overview
Adds explicit Conventional Commits guidance to CLAUDE.md, including the expected <type>(<scope>): <description> format and a note that AI attribution is stripped by the commit hook.

Aligns runtime tooling requirements by updating the root package.json engines to require node >=25.9.0 and pnpm >=10.33.0, and removes the per-package engines block from packages/cli/package.json so the repo-level constraints apply.

Reviewed by Cursor Bugbot for commit f428ab0. Configure here.

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: Node engine version contradicts PR description intent
    • Changed the node engine constraint from >=25.9.0 to >=18.20.8 to match the PR description intent and support all current LTS versions.

You can send follow-ups to the cloud agent here.

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit f428ab0. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant