Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Overview - #826
Closes #826.
The confirmation above four physical filaments is an intentional safeguard: pairwise gradients grow as
n × (n - 1) / 2. This change keeps that safeguard and adds an explicit way to remember the answer for one project, instead of bypassing confirmation application-wide.Changes Made
.3mf.Preserved Safety Behavior
Screenshots/Recordings/Graphs
The recording uses an isolated macOS arm64 build and a seven-filament fixture. It shows the 7 → 21 safeguard, remembers Yes in the project, reopens the saved
.3mfwithout prompting, then changes the physical count so the safeguard asks again for 8 → 28 gradients.Verification
-Wall -Wextra -Werror— passed, including unchanged default behavior for counts 0–32.git diff --check— passed..3mfcontainschoice = 1andphysical_count = 7.The wider local
[MixedFilament]run reaches an existing assertion inPrintRegion.cpp(wall_filament <= num_extruders) after 22 test cases / 142 assertions; that test and code path are unchanged by this PR. The repository's Ubuntu workflow also has a pre-existing Catch2 v2 include failure reproduced on the exact base commit.