Fix edge case offset handling in surface tree traversals#1954
Open
moggiesir wants to merge 1 commit intoSmithay:masterfrom
Open
Fix edge case offset handling in surface tree traversals#1954moggiesir wants to merge 1 commit intoSmithay:masterfrom
moggiesir wants to merge 1 commit intoSmithay:masterfrom
Conversation
If a subsurface (that has an offset from parent) is passed in to bbox_from_surface_tree or under_from_surface_tree and the location parameter already accounts for the offset (which is typical), then the previous logic would return an erroneous bounding box (from the parent's top left to the subsurface tree's bottom right). It seems like these functions assumed they would only be called with non-offset surfaces (e.g. top-level surfaces), and they are called that way within smithay, but they are not documented as such and they caused a weird bug in a compositor I'm creating.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix edge case offset handling in surface tree traversals by not including the offset of the surface passed in to the functions.
If a subsurface (that has an offset from parent) is passed in to bbox_from_surface_tree or under_from_surface_tree and the location parameter already accounts for the offset (which is typical), then the previous logic would return an erroneous bounding box (from the parent's top left to the subsurface tree's bottom right).
It seems like these functions assumed they would only be called with non-offset surfaces (e.g. top-level surfaces), and they are called that way within smithay, but they are not documented as such and they caused a weird bug in a compositor I'm creating.
Checklist