Draft
Conversation
when processing multiple input events we can delay re-registering the timers until all event have been processed. this safes us from cancelling and registering the timers multiple times.
22d3ae6 to
50be3c5
Compare
Collaborator
Author
|
@mayakwd I tried to further optimize this a bit, if you got some spare time I would appreciate if you can check if this lowers CPU usage for you. |
Contributor
|
FWIW niri already debounces these on its side, without using extra idles: https://github.com/niri-wm/niri/blob/8e3e93b6240dc9dbc702f0b44f20177c2ce737cf/src/niri.rs#L775-L776 |
Hey, sure. I'll check it in the evening. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when processing multiple input events we
can delay re-registering the timers until
all event have been processed.
this safes us from cancelling and registering
the timers multiple times.