add:サムネイルのテーマ対応 - #6
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the thumbnail pipeline to better support UI theming by switching cached thumbnails to transparent WebP and adjusting the thumbnail background color on the frontend so transparency renders well across themes.
Changes:
- Switch thumbnail cache output from JPEG (RGB) to WebP (RGBA) and add legacy JPEG cleanup.
- Improve Windows Shell-thumbnail padding detection to handle cases where HBITMAP alpha may be invalid.
- Update frontend thumbnail container background from
bg-blackto theme-awarebg-slate-700, and update README cache spec.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Updates cache documentation to reflect transparent WebP thumbnails. |
| client/src/components/Thumbnail.tsx | Uses theme-aware background color behind (now transparent) thumbnails. |
| client/src-tauri/src/thumbnail.rs | Generates/caches RGBA WebP thumbnails, removes legacy JPEGs, and adds an alpha-preservation test. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.