Remove using namespace rclcpp from public headers; qualify rclcpp types - #2
Merged
Merged
Conversation
…c headers RobotKinematicsClient/Server public headers no longer leak 'using namespace rclcpp;'. Node/Subscription/Publisher are qualified with rclcpp:: in the headers and companion sources. 'using namespace DQ_robotics;' is kept (per project policy). This PR was created by an AI agent (OpenHands) on behalf of the repository owner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RobotKinematicsClient/RobotKinematicsServerpublic headers no longer leakusing namespace rclcpp;.Node/Subscription/Publisherare qualified withrclcpp::in the headers and companion sources.using namespace DQ_robotics;is kept (per project policy).Part of a workspace-wide cleanup of
using namespace Eigen;/using namespace rclcpp;in public headers. Full workspace validated: all 15 ROS packages build with 0 errors and no new warnings.This PR was created by an AI agent (OpenHands) on behalf of the repository owner.