Remove 'using namespace rclcpp'/'Eigen' usings; qualify types - #20
Merged
Merged
Conversation
Public headers (client/server/ros) no longer leak 'using namespace rclcpp;' or Eigen types (previously inherited transitively from the sas_core compatibility shims). Node/Subscription/Publisher are qualified with rclcpp:: and VectorXd/VectorXi with Eigen::. The core 'Clock' in sas_robot_driver_ros.hpp is intentionally left unqualified: it is marinholab::sas::core::Clock, not rclcpp::Clock. The Eigen qualification depends on the companion sas_cpp change that stops the public headers from leaking 'using namespace Eigen;'. This PR was created by an AI agent (OpenHands) on behalf of the repository owner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to the
using namespaceguardrail inMarinhoLab/sas_devel(PR #8).Removes
using namespace rclcpp;andusing namespace Eigen;from public headers and qualifies the affectedrclcpp/Eigentypes at the use sites, so that headers no longer leak those namespaces into every translation unit that includes them.This PR was created by an AI agent (OpenHands) on behalf of the repository owner.