Remove using namespace rclcpp/Eigen from public headers; qualify types - #19
Merged
Merged
Conversation
Public headers (client/server/ros) no longer leak 'using namespace rclcpp;' or Eigen types (previously inherited transitively from the sas_core compatibility shims). Node/Subscription/Publisher are qualified with rclcpp:: and VectorXd/VectorXi with Eigen::. The core 'Clock' in sas_robot_driver_ros.hpp is intentionally left unqualified: it is marinholab::sas::core::Clock, not rclcpp::Clock. The Eigen qualification depends on the companion sas_cpp change that stops the public headers from leaking 'using namespace Eigen;'. This PR was created by an AI agent (OpenHands) on behalf of the repository owner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Public headers (client/server/ros) no longer leak
using namespace rclcpp;or bare Eigen types (previously inherited transitively from thesas_corecompatibility shims).Node/Subscription/Publisherare qualified withrclcpp::andVectorXd/VectorXiwithEigen::.Note: the core
Clockinsas_robot_driver_ros.hppis intentionally left unqualified — it ismarinholab::sas::core::Clock, notrclcpp::Clock.Depends on the companion
MarinhoLab/sas_cppPR that stops the public headers from leakingusing namespace Eigen;(until both are merged, this package builds fine because the currentlibmarinholab-sas-coredeb still provides the leak, but theEigen::qualifications are correct either way).This PR was created by an AI agent (OpenHands) on behalf of the repository owner.