Remove using namespace Eigen from public header; qualify Eigen types - #7
Merged
Merged
Conversation
The public header no longer leaks 'using namespace Eigen;'. MatrixXd/ VectorXd are qualified with Eigen:: in the header, sources and the example. The Eigen qualification depends on the companion sas_cpp change that stops the public headers from leaking 'using namespace Eigen;'. This PR was created by an AI agent (OpenHands) on behalf of the repository owner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The public header no longer leaks
using namespace Eigen;.MatrixXd/VectorXdare qualified withEigen::in the header, sources and the example.Depends on the companion
MarinhoLab/sas_cppPR that stops the public headers from leakingusing namespace Eigen;(both are correct whether or not the current deb still provides the leak).This PR was created by an AI agent (OpenHands) on behalf of the repository owner.