chore: remove using namespace Eigen from example - #2
Merged
Merged
Conversation
The example only exercises DQ/geometry_msgs conversions; the Eigen using-directive was vestigial. Co-authored-by: openhands <openhands@all-hands.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the vestigial
using namespace Eigen;from the README example, which only exercises DQ/geometry_msgs conversions.Part of a workspace-wide cleanup that removes
using namespace Eigen;/using namespace rclcpp;from headers (qualifying the affected types). Thesas_cppcompanion PR stops the transitive Eigen leak fromlibmarinholab-sas-corepublic headers that this file (and other packages) previously relied on.This PR was created by an AI agent (OpenHands) on behalf of the repository owner.