clang version check: we only support LLVM 22 now - #178
Open
simon-skylabs wants to merge 2 commits into
Open
simon-skylabs wants to merge 2 commits into
simon-skylabs wants to merge 2 commits into
Conversation
CI summary (Details)Active Repos
|
| Repo | Job Branch | Job Commit |
|---|---|---|
| fmdeps/BRiCk/ | main | 5c1989e |
| fmdeps/auto/ | main | bb92a94 |
| fmdeps/auto-docs/ | main | 6490c5f |
| bluerock/NOVA/ | skylabs-proof | eb2fd0d |
| bluerock/bhv/ | skylabs-main | e6646bb |
| fmdeps/brick-libcpp/ | main | 4a05f01 |
| fmdeps/ci/ | main | 6a09c2f |
| vendored/elpi/ | skylabs-master | c0b9653 |
| vendored/flocq/ | skylabs-master | cf9cc84 |
| vendored/rocq/ | skylabs-master | bef7df5 |
| fmdeps/rocq-agent-toolkit/ | main | 227bb83 |
| vendored/rocq-elpi/ | skylabs-master | 7dee592 |
| vendored/rocq-equations/ | skylabs-main | 9cf8471 |
| vendored/rocq-iris/ | skylabs-master | a7af9f7 |
| vendored/rocq-lsp/ | skylabs-main | 64ef78a |
| vendored/rocq-stdlib/ | skylabs-master | 00897b3 |
| vendored/rocq-stdpp/ | skylabs-master | 0c5e505 |
| fmdeps/skylabs-fm/ | main | c8da9fd |
| vendored/vsrocq/ | skylabs-main | ee79e7a |
No Changes in Warnings or Errors
| Before | New | Fixed | After | |
|---|---|---|---|---|
| Errors | 0 | 0 | 0 | 0 |
| Warnings | 120 | 0 | 0 | 120 |
Code quality details
Performance
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| -0.00% | 194115.6 | 194115.6 | -0.0 | total |
| -0.00% | 52862.3 | 52862.3 | -0.0 | ├ translation units |
| +0.00% | 141253.3 | 141253.3 | +0.0 | └ proofs and tests |
Full Results
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| -0.00% | 194115.6 | 194115.6 | -0.0 | total |
| -0.00% | 52862.3 | 52862.3 | -0.0 | ├ translation units |
| +0.00% | 141253.3 | 141253.3 | +0.0 | └ proofs and tests |
| # Setting up the development environment. | ||
|
|
||
| .PHONY: dev-setup | ||
| .PHONY: dev-setup dev-setup-full-workspace |
Contributor
There was a problem hiding this comment.
Suggested change
| .PHONY: dev-setup dev-setup-full-workspace | |
| .PHONY: dev-setup |
Not there.
rlepigre-skylabs-ai
left a comment
rlepigre-skylabs-ai
left a comment
Contributor
There was a problem hiding this comment.
I don't know that the problem at hand warrants complicating things with another Makefile target and the associated hack, to be honest. If we're going that direction, it might be better to just set MIN="22.0.0" unconditionally.
Comment on lines
-8
to
+15
| MIN="18.0.0" | ||
| FIRST_UNSUPPORTED="22.0.0" | ||
| RECOMMENDED="19.*.*" | ||
| FIRST_UNSUPPORTED="23.0.0" | ||
| if [[ $# -gt 0 ]] && [[ "$1" -eq "--full-workspace" ]]; then | ||
| MIN="22.0.0" | ||
| RECOMMENDED="22.*.*" | ||
| else | ||
| MIN="18.0.0" | ||
| RECOMMENDED="19.*.*" | ||
| fi |
Contributor
There was a problem hiding this comment.
Suggested change
| MIN="18.0.0" | |
| FIRST_UNSUPPORTED="22.0.0" | |
| RECOMMENDED="19.*.*" | |
| FIRST_UNSUPPORTED="23.0.0" | |
| if [[ $# -gt 0 ]] && [[ "$1" -eq "--full-workspace" ]]; then | |
| MIN="22.0.0" | |
| RECOMMENDED="22.*.*" | |
| else | |
| MIN="18.0.0" | |
| RECOMMENDED="19.*.*" | |
| fi | |
| MIN="19.0.0" | |
| RECOMMENDED="22.*.*" | |
| FIRST_UNSUPPORTED="23.0.0" | |
| if [[ $# -gt 0 ]] && [[ "$1" -eq "--full-workspace" ]]; then | |
| MIN="22.0.0" | |
| fi |
pgiarrusso-sl
added a commit
that referenced
this pull request
Sep 18, 2026
Non-controversial parts of #178.
pgiarrusso-sl
added a commit
that referenced
this pull request
Sep 18, 2026
Non-controversial parts of #178.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.