Sketch hints for ptr_comparable and array - #177
Draft
pgiarrusso-sl wants to merge 1 commit into
Draft
pgiarrusso-sl wants to merge 1 commit into
pgiarrusso-sl wants to merge 1 commit into
Conversation
This file seems the only current testcase for these hints (based on failures in SkyLabsAI/auto#457).
CI summary (Details)Active Repos
|
| Repo | Job Branch | Job Commit |
|---|---|---|
| ./ | main | d0ca455 |
| fmdeps/BRiCk/ | main | 837f50d |
| fmdeps/auto/ | main | c515364 |
| fmdeps/auto-docs/ | main | 9914064 |
| bluerock/NOVA/ | skylabs-proof | 948378b |
| bluerock/bhv/ | skylabs-main | 3506c0b |
| fmdeps/ci/ | main | c25c8df |
| vendored/elpi/ | skylabs-master | c0b9653 |
| vendored/flocq/ | skylabs-master | cf9cc84 |
| vendored/rocq/ | skylabs-master | bef7df5 |
| fmdeps/rocq-agent-toolkit/ | main | 21c0a16 |
| vendored/rocq-elpi/ | skylabs-master | 7dee592 |
| vendored/rocq-equations/ | skylabs-main | 9cf8471 |
| vendored/rocq-iris/ | skylabs-master | a7af9f7 |
| vendored/rocq-lsp/ | skylabs-main | 64ef78a |
| vendored/rocq-stdlib/ | skylabs-master | 00897b3 |
| vendored/rocq-stdpp/ | skylabs-master | 0c5e505 |
| fmdeps/skylabs-fm/ | main | ff17057 |
| vendored/vsrocq/ | skylabs-main | ee79e7a |
No Changes in Warnings or Errors
| Before | New | Fixed | After | |
|---|---|---|---|---|
| Errors | 0 | 0 | 0 | 0 |
| Warnings | 92 | 0 | 0 | 92 |
Performance
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| -0.05% | 198968.5 | 198877.8 | -90.8 | total |
| -0.00% | 53308.1 | 53308.1 | -0.0 | ├ translation units |
| -0.06% | 145660.5 | 145569.7 | -90.8 | └ proofs and tests |
Full Results
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| -18.02% | 503.7 | 412.9 | -90.8 | fmdeps/brick-libcpp/rocq-brick-libstdcpp/test/cstring/proof.v |
| -0.05% | 198968.5 | 198877.8 | -90.8 | total |
| -0.00% | 53308.1 | 53308.1 | -0.0 | ├ translation units |
| -0.06% | 145660.5 | 145569.7 | -90.8 | └ proofs and tests |
pgiarrusso-sl
marked this pull request as draft
September 16, 2026 12:21
Janno
reviewed
Sep 16, 2026
Janno
left a comment
Janno
left a comment
Contributor
There was a problem hiding this comment.
The hint diff data looks very good. The scope is limited, of course. But none of the new hints have false positives and no other changes in the hint data look bad in any way. We should upstream as much of this as possible, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This file seems the only current testcase for these hints (based on failures in https://github.com/SkyLabsAI/auto/pull/457).
Not ready for merging, the new hints need upstreaming.