Skip to content

feat: std::array specs - #172

Merged
jhaag-skylabs-ai merged 4 commits into
mainfrom
feat/std-array
Sep 14, 2026
Merged

jhaag-skylabs-ai merged 4 commits into
mainfrom
feat/std-array

Conversation

@jhaag-skylabs-ai

Copy link
Copy Markdown
Contributor

@skylabs-ai-ci

skylabs-ai-ci Bot commented Sep 9, 2026

Copy link
Copy Markdown

CI summary (Details)

Active Repos

Repo Job Branch Job Commit Branch Tip Base branch Base commit PR
fmdeps/brick-libcpp/ feat/std-array b677cd3 f17a48a main be863c8 #172

Passive Repos

Repo Job Branch Job Commit
./ main db1581e
fmdeps/BRiCk/ main e819c36
fmdeps/auto/ main bc4c71e
fmdeps/auto-docs/ main 6490c5f
bluerock/NOVA/ skylabs-proof f3533d2
bluerock/bhv/ skylabs-main e37df58
fmdeps/ci/ main e1ec839
vendored/elpi/ skylabs-master c0b9653
vendored/flocq/ skylabs-master cf9cc84
vendored/rocq/ skylabs-master bef7df5
fmdeps/rocq-agent-toolkit/ main 227bb83
vendored/rocq-elpi/ skylabs-master 7dee592
vendored/rocq-equations/ skylabs-main 9cf8471
vendored/rocq-iris/ skylabs-master a7af9f7
vendored/rocq-lsp/ skylabs-main 64ef78a
vendored/rocq-stdlib/ skylabs-master 00897b3
vendored/rocq-stdpp/ skylabs-master 0c5e505
fmdeps/skylabs-fm/ main 5c3d0ab
vendored/vsrocq/ skylabs-main ee79e7a

No Changes in Warnings or Errors

Before New Fixed After
Errors 0 0 0 0
Warnings 91 0 0 91

Performance

Relative Master MR Change Filename
+0.41% 198198.0 199008.5 +810.5 total
+0.41% - 810.5 +810.5 ├ newly appeared files (6)
+0.00% 198198.0 198198.0 +0.0 └ common files
+0.00% 53108.6 53108.6 +0.0 ├ translation units
+0.00% 145089.4 145089.4 +0.0 └ proofs and tests
Full Results
Relative Master MR Change Filename
+0.41% 198198.0 199008.5 +810.5 total
+0.41% - 810.5 +810.5 ├ newly appeared files (6)
+0.00% 198198.0 198198.0 +0.0 └ common files
+0.00% 53108.6 53108.6 +0.0 ├ translation units
+0.00% 145089.4 145089.4 +0.0 └ proofs and tests

Comment thread rocq-brick-libstdcpp/proof/array/spec.v
@simon-skylabs

Copy link
Copy Markdown
Contributor

Overall, I like what you did here. I went ahead and wrote a hint to handle the !!! operator. I'm going to put it in a section called UPSTREAM and push it. I'll also create a PR to upstream it. We can merge the two in any order and delete the local version when we're ready.

In your test suite, could you add a proof of two instantiations of constructors to make sure the rep predicate can be constructed?

@skylabs-ai-ci

skylabs-ai-ci Bot commented Sep 10, 2026

Copy link
Copy Markdown

CI summary (Details)

Active Repos

Repo Job Branch Job Commit Branch Tip Base branch Base commit PR
fmdeps/brick-libcpp/ feat/std-array 5036843 e085a24 main be863c8 #172

Passive Repos

Repo Job Branch Job Commit
./ main db1581e
fmdeps/BRiCk/ main e819c36
fmdeps/auto/ main 238517a
fmdeps/auto-docs/ main 6490c5f
bluerock/NOVA/ skylabs-proof f3533d2
bluerock/bhv/ skylabs-main e37df58
fmdeps/ci/ main e1ec839
vendored/elpi/ skylabs-master c0b9653
vendored/flocq/ skylabs-master cf9cc84
vendored/rocq/ skylabs-master bef7df5
fmdeps/rocq-agent-toolkit/ main 227bb83
vendored/rocq-elpi/ skylabs-master 7dee592
vendored/rocq-equations/ skylabs-main 9cf8471
vendored/rocq-iris/ skylabs-master a7af9f7
vendored/rocq-lsp/ skylabs-main 64ef78a
vendored/rocq-stdlib/ skylabs-master 00897b3
vendored/rocq-stdpp/ skylabs-master 0c5e505
fmdeps/skylabs-fm/ main 5c3d0ab
vendored/vsrocq/ skylabs-main ee79e7a

No Changes in Warnings or Errors

Before New Fixed After
Errors 0 0 0 0
Warnings 91 0 0 91

Performance

Relative Master MR Change Filename
+0.41% 198256.9 199068.0 +811.1 total
+0.41% - 811.1 +811.1 ├ newly appeared files (6)
+0.00% 198256.9 198256.9 +0.0 └ common files
+0.00% 53108.6 53108.6 +0.0 ├ translation units
+0.00% 145148.4 145148.4 +0.0 └ proofs and tests
Full Results
Relative Master MR Change Filename
+0.41% 198256.9 199068.0 +811.1 total
+0.41% - 811.1 +811.1 ├ newly appeared files (6)
+0.00% 198256.9 198256.9 +0.0 └ common files
+0.00% 53108.6 53108.6 +0.0 ├ translation units
+0.00% 145148.4 145148.4 +0.0 └ proofs and tests

@simon-skylabs

Copy link
Copy Markdown
Contributor

Update: I merged the Normalize hints into auto so I went ahead and deleted them from this PR

@skylabs-ai-ci

skylabs-ai-ci Bot commented Sep 10, 2026

Copy link
Copy Markdown

CI summary (Details)

Active Repos

Repo Job Branch Job Commit Branch Tip Base branch Base commit PR
fmdeps/brick-libcpp/ feat/std-array 9b89b7d f033b74 main be863c8 #172

Passive Repos

Repo Job Branch Job Commit
./ main db1581e
fmdeps/BRiCk/ main e819c36
fmdeps/auto/ main 7f2b19a
fmdeps/auto-docs/ main 6490c5f
bluerock/NOVA/ skylabs-proof f3533d2
bluerock/bhv/ skylabs-main e37df58
fmdeps/ci/ main e1ec839
vendored/elpi/ skylabs-master c0b9653
vendored/flocq/ skylabs-master cf9cc84
vendored/rocq/ skylabs-master bef7df5
fmdeps/rocq-agent-toolkit/ main 227bb83
vendored/rocq-elpi/ skylabs-master 7dee592
vendored/rocq-equations/ skylabs-main 9cf8471
vendored/rocq-iris/ skylabs-master a7af9f7
vendored/rocq-lsp/ skylabs-main 64ef78a
vendored/rocq-stdlib/ skylabs-master 00897b3
vendored/rocq-stdpp/ skylabs-master 0c5e505
fmdeps/skylabs-fm/ main 5c3d0ab
vendored/vsrocq/ skylabs-main ee79e7a

No Changes in Warnings or Errors

Before New Fixed After
Errors 0 0 0 0
Warnings 91 0 0 91

Performance

Relative Master MR Change Filename
+0.41% 198229.8 199039.7 +809.8 total
+0.41% - 811.1 +811.1 ├ newly appeared files (6)
-0.00% 198229.8 198228.6 -1.2 └ common files
+0.00% 53108.6 53108.6 +0.0 ├ translation units
-0.00% 145121.3 145120.1 -1.2 └ proofs and tests
Full Results
Relative Master MR Change Filename
+0.41% 198229.8 199039.7 +809.8 total
+0.41% - 811.1 +811.1 ├ newly appeared files (6)
-0.00% 198229.8 198228.6 -1.2 └ common files
+0.00% 53108.6 53108.6 +0.0 ├ translation units
-0.00% 145121.3 145120.1 -1.2 └ proofs and tests

@skylabs-ai-ci

skylabs-ai-ci Bot commented Sep 11, 2026

Copy link
Copy Markdown

CI summary (Details)

Active Repos

Repo Job Branch Job Commit Branch Tip Base branch Base commit PR
fmdeps/brick-libcpp/ feat/std-array 1ca0fe9 4f85464 main be863c8 #172

Passive Repos

Repo Job Branch Job Commit
./ main db1581e
fmdeps/BRiCk/ main e819c36
fmdeps/auto/ main 4712f6c
fmdeps/auto-docs/ main 6490c5f
bluerock/NOVA/ skylabs-proof f3533d2
bluerock/bhv/ skylabs-main e37df58
fmdeps/ci/ main e1ec839
vendored/elpi/ skylabs-master c0b9653
vendored/flocq/ skylabs-master cf9cc84
vendored/rocq/ skylabs-master bef7df5
fmdeps/rocq-agent-toolkit/ main 227bb83
vendored/rocq-elpi/ skylabs-master 7dee592
vendored/rocq-equations/ skylabs-main 9cf8471
vendored/rocq-iris/ skylabs-master a7af9f7
vendored/rocq-lsp/ skylabs-main 64ef78a
vendored/rocq-stdlib/ skylabs-master 00897b3
vendored/rocq-stdpp/ skylabs-master 0c5e505
fmdeps/skylabs-fm/ main 5c3d0ab
vendored/vsrocq/ skylabs-main ee79e7a

No Changes in Warnings or Errors

Before New Fixed After
Errors 0 0 0 0
Warnings 91 0 0 91

Performance

Relative Master MR Change Filename
+0.54% 198166.7 199245.3 +1078.6 total
+0.54% - 1078.6 +1078.6 ├ newly appeared files (6)
+0.00% 198166.7 198166.7 +0.0 └ common files
+0.00% 53108.6 53108.6 +0.0 ├ translation units
+0.00% 145058.2 145058.2 +0.0 └ proofs and tests
Full Results
Relative Master MR Change Filename
+0.54% 198166.7 199245.3 +1078.6 total
+0.54% - 1078.6 +1078.6 ├ newly appeared files (6)
+0.00% 198166.7 198166.7 +0.0 └ common files
+0.00% 53108.6 53108.6 +0.0 ├ translation units
+0.00% 145058.2 145058.2 +0.0 └ proofs and tests

Comment thread rocq-brick-libstdcpp/test/array/test_cpp_proof.v Outdated
Comment thread rocq-brick-libstdcpp/test/array/test_cpp_proof.v
@skylabs-ai-ci

skylabs-ai-ci Bot commented Sep 14, 2026

Copy link
Copy Markdown

CI summary (Details)

Active Repos

Repo Job Branch Job Commit Branch Tip Base branch Base commit PR
fmdeps/brick-libcpp/ feat/std-array 1c5b4f0 600cbab main be863c8 #172

Passive Repos

Repo Job Branch Job Commit
./ main d0ca455
fmdeps/BRiCk/ main 7512717
fmdeps/auto/ main 4712f6c
fmdeps/auto-docs/ main 6490c5f
bluerock/NOVA/ skylabs-proof f3533d2
bluerock/bhv/ skylabs-main 7407bfd
fmdeps/ci/ main e1ec839
vendored/elpi/ skylabs-master c0b9653
vendored/flocq/ skylabs-master cf9cc84
vendored/rocq/ skylabs-master bef7df5
fmdeps/rocq-agent-toolkit/ main 4783bd7
vendored/rocq-elpi/ skylabs-master 7dee592
vendored/rocq-equations/ skylabs-main 9cf8471
vendored/rocq-iris/ skylabs-master a7af9f7
vendored/rocq-lsp/ skylabs-main 64ef78a
vendored/rocq-stdlib/ skylabs-master 00897b3
vendored/rocq-stdpp/ skylabs-master 0c5e505
fmdeps/skylabs-fm/ main 5c3d0ab
vendored/vsrocq/ skylabs-main ee79e7a

No Changes in Warnings or Errors

Before New Fixed After
Errors 0 0 0 0
Warnings 92 0 0 92

Performance

Relative Master MR Change Filename
+0.55% 198520.4 199603.5 +1083.2 total
+0.54% - 1083.2 +1083.2 ├ newly appeared files (6)
-0.00% 198520.4 198520.4 -0.0 └ common files
-0.00% 53106.9 53106.9 -0.0 ├ translation units
+0.00% 145413.5 145413.5 +0.0 └ proofs and tests
Full Results
Relative Master MR Change Filename
+0.55% 198520.4 199603.5 +1083.2 total
+0.54% - 1083.2 +1083.2 ├ newly appeared files (6)
-0.00% 198520.4 198520.4 -0.0 └ common files
-0.00% 53106.9 53106.9 -0.0 ├ translation units
+0.00% 145413.5 145413.5 +0.0 └ proofs and tests

@jhaag-skylabs-ai
jhaag-skylabs-ai merged commit fcbd1f1 into main Sep 14, 2026
11 checks passed
@jhaag-skylabs-ai
jhaag-skylabs-ai deleted the feat/std-array branch September 14, 2026 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants