Skip to content

istream: restrict integer extraction to representable values (#152) #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mahadkhan811 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

istream: restrict integer extraction to representable values (#152) #171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions rocq-brick-libstdcpp/proof/iostream/spec.v
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,11 @@ Module istream.
end
).

(** TODO: this specification is unsound because it needs to re-buffer the
(** This contract only covers parsed values representable as [int].
Out-of-range extraction saturates and sets [failbit], which the current
stream predicate does not model.

TODO: this specification is unsound because it needs to re-buffer the
next character that it read (the first component of the pair returned by
[read_int]).
*)
Expand All @@ -228,7 +232,9 @@ Module istream.
\pre{IS isM} this |-> istream.R IS isM 1$m
\arg{nP} "" (Vref nP)
\pre nP |-> anyR "int" 1$m
\pre{K : Z -> mpred} interp_itree as_event IS read_int (K ∘ snd)
\pre{K : Z -> mpred} interp_itree as_event IS read_int (fun '(_, n) =>
[| (int_rank.min_val int_rank.Iint Signed <= n <=
int_rank.max_val int_rank.Iint Signed)%Z |] ** K n)
\post[Vptr this] Exists isM' n,
this |-> istream.R IS isM' 1$m **
nP |-> intR 1$m n **
Expand Down