Mutex spec tweaks - #167
Open
pgiarrusso-sl wants to merge 4 commits into
Open
pgiarrusso-sl wants to merge 4 commits into
pgiarrusso-sl wants to merge 4 commits into
Conversation
CI summary (Details)Active Repos
|
| Repo | Job Branch | Job Commit |
|---|---|---|
| ./ | main | db1581e |
| fmdeps/BRiCk/ | main | 389d262 |
| fmdeps/auto/ | main | 1158e34 |
| fmdeps/auto-docs/ | main | 6490c5f |
| bluerock/NOVA/ | skylabs-proof | bbb220a |
| bluerock/bhv/ | skylabs-main | e6646bb |
| fmdeps/ci/ | main | 6a09c2f |
| vendored/elpi/ | skylabs-master | c0b9653 |
| vendored/flocq/ | skylabs-master | cf9cc84 |
| vendored/rocq/ | skylabs-master | bef7df5 |
| fmdeps/rocq-agent-toolkit/ | main | 227bb83 |
| vendored/rocq-elpi/ | skylabs-master | 7dee592 |
| vendored/rocq-equations/ | skylabs-main | 9cf8471 |
| vendored/rocq-iris/ | skylabs-master | a7af9f7 |
| vendored/rocq-lsp/ | skylabs-main | 64ef78a |
| vendored/rocq-stdlib/ | skylabs-master | 00897b3 |
| vendored/rocq-stdpp/ | skylabs-master | 0c5e505 |
| fmdeps/skylabs-fm/ | main | 69d6d20 |
| vendored/vsrocq/ | skylabs-main | ee79e7a |
Changes in Warnings or Errors
| Before | New | Fixed | After | |
|---|---|---|---|---|
| Errors | 0 | 0 | 1 | |
| Warnings | 117 | 0 | 0 | 117 |
Code quality details
Rocq Files with Errors (1)
# Files with new errors
- fmdeps/brick-libcpp/rocq-brick-libstdcpp/test/mutex/test_cpp_proof.v
❌ New Errors (1)
File "./fmdeps/brick-libcpp/rocq-brick-libstdcpp/test/mutex/test_cpp_proof.v", line 17, characters 2-6:
Error: (in proof test_mutex_ok): Attempt to save an incomplete proof
(there are remaining open goals).
Performance
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| -0.08% | 197191.3 | 197027.9 | -163.4 | total |
| -0.08% | 157.7 | - | -157.7 | ├ disappeared files (1) |
| -0.00% | 197033.6 | 197027.9 | -5.7 | └ common files |
| -0.00% | 53107.4 | 53107.4 | -0.0 | ├ translation units |
| -0.00% | 143926.3 | 143920.5 | -5.7 | └ proofs and tests |
Full Results
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| -2.90% | 50.3 | 48.9 | -1.5 | fmdeps/brick-libcpp/rocq-brick-libstdcpp/proof/mutex/proof/unique_lock.v |
| -2.04% | 51.2 | 50.2 | -1.0 | fmdeps/brick-libcpp/rocq-brick-libstdcpp/proof/mutex/proof/unique_lock_recursive_mutex.v |
| -1.67% | 71.0 | 69.8 | -1.2 | fmdeps/brick-libcpp/rocq-brick-libstdcpp/proof/mutex/demo_cpp_proof.v |
| -1.22% | 99.0 | 97.8 | -1.2 | fmdeps/brick-libcpp/rocq-brick-libstdcpp/test/mutex/guard_recursive_cpp_proof.v |
| -0.08% | 197191.3 | 197027.9 | -163.4 | total |
| -0.08% | 157.7 | - | -157.7 | ├ disappeared files (1) |
| -0.00% | 197033.6 | 197027.9 | -5.7 | └ common files |
| -0.00% | 53107.4 | 53107.4 | -0.0 | ├ translation units |
| -0.00% | 143926.3 | 143920.5 | -5.7 | └ proofs and tests |
pgiarrusso-sl
force-pushed
the
paolo/mutex-spec-tweaks
branch
from
September 4, 2026 13:32
94220b8 to
9ff7f12
Compare
CI summary (Details)Active Repos
|
| Repo | Job Branch | Job Commit |
|---|---|---|
| ./ | main | db1581e |
| fmdeps/BRiCk/ | main | 389d262 |
| fmdeps/auto/ | main | 1158e34 |
| fmdeps/auto-docs/ | main | 6490c5f |
| bluerock/NOVA/ | skylabs-proof | bbb220a |
| bluerock/bhv/ | skylabs-main | e6646bb |
| fmdeps/ci/ | main | ff64512 |
| vendored/elpi/ | skylabs-master | c0b9653 |
| vendored/flocq/ | skylabs-master | cf9cc84 |
| vendored/rocq/ | skylabs-master | bef7df5 |
| fmdeps/rocq-agent-toolkit/ | main | 227bb83 |
| vendored/rocq-elpi/ | skylabs-master | 7dee592 |
| vendored/rocq-equations/ | skylabs-main | 9cf8471 |
| vendored/rocq-iris/ | skylabs-master | a7af9f7 |
| vendored/rocq-lsp/ | skylabs-main | 64ef78a |
| vendored/rocq-stdlib/ | skylabs-master | 00897b3 |
| vendored/rocq-stdpp/ | skylabs-master | 0c5e505 |
| fmdeps/skylabs-fm/ | main | 69d6d20 |
| vendored/vsrocq/ | skylabs-main | ee79e7a |
No Changes in Warnings or Errors
| Before | New | Fixed | After | |
|---|---|---|---|---|
| Errors | 0 | 0 | 0 | 0 |
| Warnings | 117 | 0 | 0 | 117 |
Code quality details
Performance
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| +0.00% | 197191.3 | 197192.1 | +0.8 | total |
| +0.00% | 53107.4 | 53107.4 | +0.0 | ├ translation units |
| +0.00% | 144083.9 | 144084.7 | +0.8 | └ proofs and tests |
Full Results
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| -2.90% | 50.3 | 48.9 | -1.5 | fmdeps/brick-libcpp/rocq-brick-libstdcpp/proof/mutex/proof/unique_lock.v |
| -2.04% | 51.2 | 50.2 | -1.0 | fmdeps/brick-libcpp/rocq-brick-libstdcpp/proof/mutex/proof/unique_lock_recursive_mutex.v |
| -1.67% | 71.0 | 69.8 | -1.2 | fmdeps/brick-libcpp/rocq-brick-libstdcpp/proof/mutex/demo_cpp_proof.v |
| -1.22% | 99.0 | 97.8 | -1.2 | fmdeps/brick-libcpp/rocq-brick-libstdcpp/test/mutex/guard_recursive_cpp_proof.v |
| +4.12% | 157.7 | 164.2 | +6.5 | fmdeps/brick-libcpp/rocq-brick-libstdcpp/test/mutex/test_cpp_proof.v |
| +0.00% | 197191.3 | 197192.1 | +0.8 | total |
| +0.00% | 53107.4 | 53107.4 | +0.0 | ├ translation units |
| +0.00% | 144083.9 | 144084.7 | +0.8 | └ proofs and tests |
pgiarrusso-sl
force-pushed
the
paolo/mutex-spec-tweaks
branch
from
September 10, 2026 16:06
9ff7f12 to
1770be1
Compare
CI summary (Details)Active Repos
|
| Repo | Job Branch | Job Commit |
|---|---|---|
| ./ | main | db1581e |
| fmdeps/BRiCk/ | main | e819c36 |
| fmdeps/auto/ | main | 0d2d68d |
| fmdeps/auto-docs/ | main | 6490c5f |
| bluerock/NOVA/ | skylabs-proof | f3533d2 |
| bluerock/bhv/ | skylabs-main | e37df58 |
| fmdeps/ci/ | main | e1ec839 |
| vendored/elpi/ | skylabs-master | c0b9653 |
| vendored/flocq/ | skylabs-master | cf9cc84 |
| vendored/rocq/ | skylabs-master | bef7df5 |
| fmdeps/rocq-agent-toolkit/ | main | 227bb83 |
| vendored/rocq-elpi/ | skylabs-master | 7dee592 |
| vendored/rocq-equations/ | skylabs-main | 9cf8471 |
| vendored/rocq-iris/ | skylabs-master | a7af9f7 |
| vendored/rocq-lsp/ | skylabs-main | 64ef78a |
| vendored/rocq-stdlib/ | skylabs-master | 00897b3 |
| vendored/rocq-stdpp/ | skylabs-master | 0c5e505 |
| fmdeps/skylabs-fm/ | main | 5c3d0ab |
| vendored/vsrocq/ | skylabs-main | ee79e7a |
No Changes in Warnings or Errors
| Before | New | Fixed | After | |
|---|---|---|---|---|
| Errors | 0 | 0 | 0 | 0 |
| Warnings | 91 | 0 | 0 | 91 |
Performance
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| +0.00% | 198220.5 | 198221.2 | +0.7 | total |
| -0.00% | 53108.6 | 53108.6 | -0.0 | ├ translation units |
| +0.00% | 145112.0 | 145112.7 | +0.7 | └ proofs and tests |
Full Results
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| -3.02% | 50.4 | 48.9 | -1.5 | fmdeps/brick-libcpp/rocq-brick-libstdcpp/proof/mutex/proof/unique_lock.v |
| -2.06% | 51.3 | 50.3 | -1.1 | fmdeps/brick-libcpp/rocq-brick-libstdcpp/proof/mutex/proof/unique_lock_recursive_mutex.v |
| -1.66% | 71.1 | 69.9 | -1.2 | fmdeps/brick-libcpp/rocq-brick-libstdcpp/proof/mutex/demo_cpp_proof.v |
| -1.21% | 99.1 | 97.9 | -1.2 | fmdeps/brick-libcpp/rocq-brick-libstdcpp/test/mutex/guard_recursive_cpp_proof.v |
| +4.13% | 157.8 | 164.3 | +6.5 | fmdeps/brick-libcpp/rocq-brick-libstdcpp/test/mutex/test_cpp_proof.v |
| +0.00% | 198220.5 | 198221.2 | +0.7 | total |
| -0.00% | 53108.6 | 53108.6 | -0.0 | ├ translation units |
| +0.00% | 145112.0 | 145112.7 | +0.7 | └ proofs and tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #160 but mergeable.