Skip to content

[MS-1544] Fixing issue with auto-capture. 'Start capture' now properly starts capturing #1785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexandr-simprints merged 1 commit into from
Aug 13, 2026
Merged

[MS-1544] Fixing issue with auto-capture. 'Start capture' now properly starts capturing #1785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ure/src/main/java/com/simprints/face/capture/screens/livefeedback/LiveFeedbackFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ internal class LiveFeedbackFragment : Fragment(R.layout.fragment_live_feedback)
}

private fun renderFeedbackOnButton(state: LiveFeedbackState) = with(binding) {
val feedback = if (state.isAutoCapture && state.phase != LiveFeedbackState.Phase.CAPTURING) {
val feedback = if (state.isAutoCapture && vm.isAutoCaptureHeldOff) {
LiveFeedbackState.Feedback.NONE
} else {
state.feedback
Expand Down
3 changes: 2 additions & 1 deletion ...re/src/main/java/com/simprints/face/capture/screens/livefeedback/LiveFeedbackViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,8 @@ internal class LiveFeedbackViewModel @Inject constructor(

private var captureImagingStartTime: Long = 0
private var validationStartTime: Long = 0
private var isAutoCaptureHeldOff = true
var isAutoCaptureHeldOff = true
private set
Comment thread
alexandr-simprints marked this conversation as resolved.
private var autoCaptureImagingTimeoutJob: Job? = null
private var autoCaptureImagingDurationMillis: Long = FACE_AUTO_CAPTURE_IMAGING_DURATION_MILLIS_DEFAULT
private lateinit var faceDetector: FaceDetector
Expand Down