[MS-1541] Stop event sync retries on network connection failure - #1782
Draft
meladRaouf wants to merge 6 commits into
Draft
[MS-1541] Stop event sync retries on network connection failure#1782meladRaouf wants to merge 6 commits into
meladRaouf wants to merge 6 commits into
Conversation
Contributor
|
@meladRaouf can you please stack this on top of #1783? There was a significant rework and it might need slightly different approach. |
meladRaouf
changed the base branch from
main
to
feature/MS-1538-sync-worker-errors
August 12, 2026 14:27
luhmirin-s
force-pushed
the
bugfix/extra-events-offline
branch
from
August 13, 2026 12:58
b8599d6 to
49f3139
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MS-1541
Will be released in: 2026.3.0
Root cause analysis (for bugfixes only)
First known affected version: 2026.3.0
EventUpSyncTask.uploadEventScopeTyperetries uploading closed event scopes in awhileloop with no delay/backoff.authStore.getFirebaseToken()under the hood, which throwsNetworkConnectionExceptionwhenFirebaseAuthManagercan't reach the network. This is caught and unconditionally logs a newEventUpSyncRequestEvent, unlike the success path which only logs when there's useful content.getClosedEventScopesCount(...) > 0) stays true, so it retries immediately with no backoff — spinning indefinitely while offline and creating a new event on every iteration, which shows up as accumulating extra events on the dashboard sync screen.Changes
EventUpSyncTask.uploadEventScopeType: when the upload fails with aNetworkConnectionException, break out of the retry loop for that scope type instead of retrying immediately, deferring the retry to the next scheduled sync attempt. This limits the failure to a single logged event per sync run while offline instead of an unbounded tight loop.Testing guidance
Additional work checklist