MS-1492 Add a configuration to show parental consent by default - #1778
Merged
Conversation
luhmirin-s
requested review from
a team,
BurningAXE,
TristramN,
alex-vt,
alexandr-simprints,
meladRaouf and
ybourgery
and
a lite review from Copilot
and removed request for
a team
August 11, 2026 12:46
There was a problem hiding this comment.
Pull request overview
Adds an experimental custom-config flag to default the Consent UI to the Parental consent tab when parental consent is allowed, wiring the flag through the config-store model and into the consent screen’s initial state.
Changes:
- Added
useParentalConsentAsDefaultparsing toExperimentalProjectConfigurationplus unit tests. - Updated
ConsentViewModelto select the initial consent tab based on the experimental flag (only when parental consent is enabled). - Updated consent feature tests and moved tab index constants into the ViewModel for shared use.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| infra/config-store/src/main/java/com/simprints/infra/config/store/models/ExperimentalProjectConfiguration.kt | Adds a new experimental boolean flag accessor and the backing config key constant. |
| infra/config-store/src/test/java/com/simprints/infra/config/store/models/ExperimentalProjectConfigurationTest.kt | Adds unit test coverage for the new config flag parsing. |
| feature/consent/src/main/java/com/simprints/feature/consent/screens/consent/ConsentViewModel.kt | Applies the new flag when computing initial consent tab selection; refactors tab constants. |
| feature/consent/src/main/java/com/simprints/feature/consent/screens/consent/ConsentFragment.kt | Reuses tab constants from ConsentViewModel instead of local duplicates. |
| feature/consent/src/test/java/com/simprints/feature/consent/screens/consent/ConsentViewModelTest.kt | Extends tests to assert initial tab selection behavior and exercises the experimental flag path. |
Suppressed comments (1)
feature/consent/src/test/java/com/simprints/feature/consent/screens/consent/ConsentViewModelTest.kt:101
- Avoid duplicating the custom-config key string in tests; using the shared constant reduces the chance of mismatches if the key ever changes.
every { projectConfig.custom } returns mapOf("useParentalConsentAsDefault" to JsonPrimitive(true))
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
luhmirin-s
force-pushed
the
feature/MS-1492-default-consent-config
branch
from
August 11, 2026 13:24
3c90d40 to
5942c6d
Compare
|
meladRaouf
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



JIRA ticket
Will be released in: 2026.3.0
Notable changes
Testing guidance
Additional work checklist