Skip to content

[3.0] Only remove permanent hooks if requested to #9699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
live627 merged 1 commit into from
Sep 22, 2026
Merged

[3.0] Only remove permanent hooks if requested to #9699

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 21 additions & 19 deletions Sources/IntegrationHook.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,25 +305,27 @@ public static function remove(string $name, string $function, bool $permanent =
$enabled_call = rtrim($function, '!');
$disabled_call = $enabled_call . '!';

// Get the permanent functions.
$request = Db::$db->query(
'SELECT value
FROM {db_prefix}settings
WHERE variable = {string:variable}',
[
'variable' => $name,
],
);
list($current_functions) = Db::$db->fetch_row($request);
Db::$db->free_result($request);

if (!empty($current_functions)) {
$current_functions = explode(',', $current_functions);

// Cleanup enabled and disabled variants.
$current_functions = array_unique(array_diff($current_functions, [$enabled_call, $disabled_call]));

Config::updateModSettings([$name => implode(',', $current_functions)]);
if ($permanent) {
// Get the permanent functions.
$request = Db::$db->query(
'SELECT value
FROM {db_prefix}settings
WHERE variable = {string:variable}',
[
'variable' => $name,
],
);
list($current_functions) = Db::$db->fetch_row($request);
Db::$db->free_result($request);

if (!empty($current_functions)) {
$current_functions = explode(',', $current_functions);

// Cleanup enabled and disabled variants.
$current_functions = array_unique(array_diff($current_functions, [$enabled_call, $disabled_call]));

Config::updateModSettings([$name => implode(',', $current_functions)]);
}
}

// Turn the function list into something usable.
Expand Down
Loading