Skip to content

[3.0] Introduce Auto review test suite - #9683

Draft
live627 wants to merge 2 commits into
SimpleMachines:release-3.0from
live627:autoreview
Draft

live627 wants to merge 2 commits into
SimpleMachines:release-3.0from
live627:autoreview

Conversation

@live627

@live627 live627 commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Introduce an auto-review PHPUnit test suite and run it in CI.

This is inspired by the auto-review test suite in PHP-CS-Fixer, which has been valuable for providing immediate feedback on pull requests and guidance on things that need to be changed before review.

The goal is to build a similar set of automated checks for SMF that can catch project-specific issues that existing tools such as PHPUnit, PHP-CS-Fixer, and Composer validation do not cover.

Changes

  • Add an auto-review PHPUnit testsuite for tests/AutoReview.

  • Run the auto-review suite as part of the PHP GitHub Actions workflow.

  • Add ComposerFileTest to check that:

    • Custom Composer scripts have descriptions.
    • There are no descriptions for undefined scripts.
    • Composer lifecycle event scripts are not incorrectly required to have descriptions.
    • The configured config.platform.php version satisfies the declared PHP requirement.
  • Add the standard tests/AutoReview/index.php entry point.

Motivation

The intention is not to duplicate checks already performed by existing tooling. Instead, the auto-review suite should provide fast, actionable feedback for project-specific conventions and relationships that are difficult or impossible for those tools to validate.

For example, a Composer configuration can be syntactically valid and pass Composer's own validation while still containing a project-specific inconsistency that we want to catch automatically.

This suite can be expanded over time as additional review patterns are identified.

Future direction

Eventually, the auto-review suite should cover a broader range of SMF-specific checks that other automated tools do not catch, providing contributors with immediate feedback and guidance during pull requests rather than discovering these issues later during manual review.

@github-actions github-actions Bot added github_actions Pull requests that update GitHub Actions code Unit Testing labels Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code Unit Testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant