[3.0] Theme split (wave 10) — remove the calendar right-to-left rules nothing matches - #9667
Open
albertlast wants to merge 1 commit into
Open
albertlast wants to merge 1 commit into
albertlast wants to merge 1 commit into
Conversation
calendar.rtl.css mirrors three selectors that no longer exist anywhere in SMF: #main_grid table.weeklist td.windowbg, #main_grid table.weeklist td.weekdays and #main_grid img.calendar_icon. Nothing in Sources or Themes emits a weeklist, weekdays or calendar_icon class, under those names or built up from parts, and calendar.css carries no counterpart for any of the three either. The week view is drawn from days, act_day, event_col, holiday_col and birthday_col instead, so the base stylesheet has already moved on and only the right-to-left file still describes the old table. The three rules were the only readers of --calendar-weeklist-border-color, so its definitions in variables.css and dark.css go with them. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: albertlast <mathiaspapealbert@hotmail.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
calendar.rtl.cssmirrors three selectors that no longer exist anywhere in SMF:#main_grid table.weeklist td.windowbg#main_grid table.weeklist td.weekdays#main_grid img.calendar_iconNothing in
Sources/orThemes/emits aweeklist,weekdaysorcalendar_iconclass — not under those names, and not built up from parts either, which is worth checking separately because a class name can arrive constructed rather than written out.calendar.csshas no counterpart for any of the three, so the base stylesheet has already moved on and only the right-to-left file still describes the old table.The week view is drawn from
days,act_day,event_col,holiday_colandbirthday_col, built inCalendar.template.php— a different structure entirely.The three rules were also the only readers of
--calendar-weeklist-border-color, so its definitions invariables.cssanddark.cssgo with them.What stays, and why
The two remaining rules in the file are deliberately left alone. Neither is an exact mirror of a base rule, so neither can be written as a logical property without changing the left-to-right result as well:
#main_grid .cat_bar { margin: 0 0 0 2px; }has no counterpart incalendar.cssat all — it adds a margin only in right-to-left.#month_grid { margin: 0 0 0 1%; }faces a basemargin-right: 10px. That is a different value, not the same value on the mirrored side.This follows the same rule the earlier waves used: a declaration only becomes logical when the override is precisely the base value with the sides swapped.
This is the last right-to-left override file, and with these rules gone it holds only the two that have to stay.
Issues References (Fixes|Related|Closes)
Related to #7933.
🤖 Generated with Claude Code