[3.0] Remove the stylesheet the installer stopped using - #9664
Merged
jdarwood007 merged 1 commit intoSep 8, 2026
Merged
jdarwood007 merged 1 commit into
jdarwood007 merged 1 commit into
Conversation
Themes/default/css/install.css is loaded by nothing. The installer and the upgrader were rewritten for 3.0, and MaintenanceTemplate.php asks for variables.css, index.css, maintenance.css and, in a right-to-left language, rtl.css. In 2.1 the file was pulled in by other/install.php and other/upgrade.php, which is where its last references went. Nothing else reaches it either. The name appears nowhere in the repository, and it cannot arrive by a computed name: the only place a stylesheet is loaded from a variable is Theme::loadTemplate(), whose two callers both ask for 'admin'. Confirmed by running both tools: install.php and upgrade.php each return 200 and request variables.css, index.css and maintenance.css, with nothing logged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: albertlast <mathiaspapealbert@hotmail.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Themes/default/css/install.css— 182 lines — is loaded by nothing.The installer and upgrader were rewritten for 3.0, and
MaintenanceTemplate.phpnow asksfor
variables.css,index.css,maintenance.cssand, in a right-to-left language,rtl.css. In 2.1 this file was pulled in byother/install.phpandother/upgrade.php,and those were its last references — they went with the rewrites in
572704635and99321ba41.How I know nothing reaches it
Grepping for the name is not enough on its own, since a stylesheet can arrive under a
computed name, so both were checked:
install.cssappears nowhere in the repository outsidevendor/Theme::loadTemplate(), atSources/Theme.php:406— and its two callers, inModeration\MainandPackageManager, both ask for'admin'Then both tools were actually run:
install.phpandupgrade.phpeach return 200 andrequest
variables.css,index.cssandmaintenance.css. Nothing was logged.Not to be confused with
maintenance.cssis the file the installer and upgrader really use, and it is untouchedhere.
Issues References (Fixes|Related|Closes)
Found while scoping the remaining work on #7933; unrelated to that PR's contents — the
snapshot it ports from keeps this file too.
🤖 Generated with Claude Code