[3.0] Theme split (wave 9, part 2) — clear the post sections with inline-end - #9663
Merged
jdarwood007 merged 1 commit intoSep 8, 2026
Conversation
index.css clears .signature, .attachments, .under_message and the two custom field blocks in one rule, and rtl.css mirrored three of the five. clear: inline-end follows the writing direction, so the override is no longer needed and all five behave the same way as each other. The two that rtl.css did not mirror change side in a right-to-left language, which is why wave 8 left this group alone. It turns out not to matter, because the clear does nothing to any of the five: the same rule gives them width: 100% and overflow: auto, and a box with its own block formatting context does not overlap a preceding float. At full width it cannot sit beside one either, so it is already pushed below - which is what the clear was asking for. Measured rather than assumed. Toggling clear through none, left, right and both on all five, in both writing directions and at 1280px, 700px and 470px wide, moves none of them by a single pixel. Only .under_message renders on the test forum's posts, so the other four were injected into the live document to be measured. Then the usual sweep of 18 pages, recording clear, float, display and the bounding rectangle of every element, before and after, back to back: - left-to-right: 4732 elements, one difference, the clear keyword itself - right-to-left: 4732 elements, one difference, the same keyword No geometry changed in either direction. The right-to-left case is the one that matters, since that is where two of the five swap the side they clear. rtl.css goes from 366 lines to 361. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: albertlast <mathiaspapealbert@hotmail.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part 2 of wave 9 of the #7933 split.
index.cssclears.signature,.attachments,.under_messageand the two custom fieldblocks in one rule, and
rtl.cssmirrored three of the five.clear: inline-endfollows the writing direction, so the override is no longer needed and all five behave the
same as each other.
Why wave 8 skipped this, and why it is safe now
Wave 8 (#9571) converted every
clearwhose override was an exact mirror, and deliberatelyleft this group alone: the two that
rtl.cssdoes not mirror would change the side theyclear in a right-to-left language, which is a behaviour change rather than a no-op.
That turns out not to matter, because the
cleardoes nothing to any of the five.The same rule also gives them
width: 100%andoverflow: auto.overflow: automakesthe box a block formatting context root, and such a box does not overlap a preceding float
— at full width it cannot sit beside one either, so it is already pushed below it. That is
exactly what the
clearwas asking for. The declaration has been redundant all along,which is why nobody noticed the two missing mirrors.
Measured, not assumed
Toggling
clearthroughnone,left,rightandbothon all five elements — in bothwriting directions, at 1280px, 700px and 470px wide:
none of them moves by a single pixel.
Only
.under_messagerenders on the test forum's posts (no signature, attachments orcustom fields on them), so the other four were injected into the live document in their
real position in order to be measured.
Then the usual sweep of 18 pages, recording
clear,float,displayand the boundingrectangle of every element, before and after, captured back to back:
clearkeyword itselfNo geometry changed in either direction. The right-to-left result is the one that matters,
since that is where two of the five swap the side they clear.
rtl.cssgoes from 366 lines to 361. With this, everyclearin the theme that can beexpressed logically is.
Issues References (Fixes|Related|Closes)
Part of the #7933 split; finishes the
clearwork started in #9571.🤖 Generated with Claude Code