Skip to content

[3.0] Says so when the table being described is unlogged #9655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
albertlast wants to merge 1 commit into
base: release-3.0
Choose a base branch
from
Open

[3.0] Says so when the table being described is unlogged #9655

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion Sources/Db/APIs/PostgreSQL.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1071,8 +1071,34 @@ public function table_sql(string $table_name): string
// Drop it if it exists.
$schema_create = 'DROP TABLE IF EXISTS ' . $table_name . ';' . "\n\n";

// A table that is not written to the write-ahead log says so in the way
// it is made, and sessions, log_online and log_floodcontrol are all built
// that way. Rebuilding one from this without saying so would quietly give
// it a durability it was never meant to pay for.
$unlogged = '';

$persistence = $this->query(
'SELECT c.relpersistence
FROM pg_class AS c
INNER JOIN pg_namespace AS n ON (n.oid = c.relnamespace)
WHERE c.relname = {string:table}
AND n.nspname = {string:schema}',
[
'table' => $table_name,
'schema' => 'public',
],
);

$row = $this->fetch_assoc($persistence);

if (\is_array($row) && $row['relpersistence'] === 'u') {
$unlogged = 'UNLOGGED ';
}

$this->free_result($persistence);

// Start the create table...
$schema_create .= 'CREATE TABLE ' . $table_name . ' (' . "\n";
$schema_create .= 'CREATE ' . $unlogged . 'TABLE ' . $table_name . ' (' . "\n";
$index_create = '';
$seq_create = '';

Expand Down