Skip to content

[3.0] Measures a display name against the column that has to hold it #9619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
albertlast wants to merge 1 commit into
base: release-3.0
Choose a base branch
from
+12 −2
Open

[3.0] Measures a display name against the column that has to hold it #9619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Sources/Actions/Register2.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,8 +212,13 @@ function (&$value, $key) {
Db::$db->free_result($request);
}

// What gets stored is the entity encoded form of the name, which is
// wider than what was typed wherever a character needs an entity,
// and real_name holds 255 characters.
$encoded_name = Utils::htmlspecialchars($_POST['real_name'], ENT_QUOTES);

// Only set it if you can and if we are sure it is good
if ($can_edit_display_name && Utils::htmlTrim($_POST['real_name']) != '' && !Security::isReservedName($_POST['real_name']) && Utils::entityStrlen($_POST['real_name']) < 60) {
if ($can_edit_display_name && Utils::htmlTrim($_POST['real_name']) != '' && !Security::isReservedName($_POST['real_name']) && Utils::entityStrlen($_POST['real_name']) < 60 && mb_strlen($encoded_name) <= 255) {
$this->possible_strings[] = 'real_name';
}
}
Expand Down
7 changes: 6 additions & 1 deletion Sources/Profile.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,7 +698,12 @@ public function loadStandardFields(bool $force_reload = false): void
return 'no_name';
}

if (Utils::entityStrlen($value) > 60) {
// The name is stored with entities in place of the characters
// that need them, so it is wider in the column than it was in
// the box: a double quote costs six characters there, an
// ampersand five. real_name holds 255, and a name inside the
// 60 character limit can still be wider than that.
if (Utils::entityStrlen($value) > 60 || mb_strlen($value) > 255) {
return 'name_too_long';
}

Expand Down