Add an ISO 3166-1 assignment predicate - #598
Open
chrisdakin wants to merge 1 commit into
Open
chrisdakin wants to merge 1 commit into
chrisdakin wants to merge 1 commit into
Conversation
chrisdakin
force-pushed
the
cdakin/worldwide-iso-assigned
branch
3 times, most recently
from
September 18, 2026 14:05
9169862 to
14bc70a
Compare
chrisdakin
marked this pull request as ready for review
September 18, 2026 15:02
chrisdakin
force-pushed
the
cdakin/worldwide-iso-assigned
branch
from
September 18, 2026 15:05
14bc70a to
3f42d5c
Compare
rochlefebvre
self-requested a review
September 18, 2026 16:28
rochlefebvre
approved these changes
Sep 18, 2026
alaar
approved these changes
Sep 18, 2026
najibna
reviewed
Sep 21, 2026
najibna
left a comment
najibna
left a comment
There was a problem hiding this comment.
The predicate is clear, and the tests cover assigned codes, reserved/user-assigned codes, subdivisions, and lookup aliases.
One note: the YAML snapshot cites Wikipedia. A pointer to the ISO 3166-1 Maintenance Agency list would make the source of the 249 codes easier to re-check later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Region#iso_3166_code_assigned? to identify regions with currently assigned ISO 3166-1 alpha-2 codes.
Check the resolved region's iso_code against a frozen set of 249 assigned codes.
Reference: https://en.wikipedia.org/wiki/ISO_3166-1_alpha-2#Officially_assigned_code_elements