Conversation
SimonSiju
force-pushed
the
simonsiju/date-at-time-with-seconds-format
branch
from
September 9, 2026 19:58
f482577 to
e7456b5
Compare
SimonSiju
marked this pull request as draft
September 11, 2026 19:43
:date_time_current_year with the time upgraded to second precision, for
cross-system log/event correlation where the exact second matters. Each locale
keeps its own field order, separators, and 12h/24h clock:
en Dec 26, 1:23:45 pm (12-hour)
fr 26 déc. 13:23:45 (24-hour, day-first)
vi 13:23:45, 26 Thg 12 (time-first)
da 26. dec. 13.23.45 ('.' separators)
- Add to DATETIME_FORMAT_MAP (datetime.short combiner + MMMd + time.medium)
in the CLDR locale generator
- Regenerate data/other/generated/*.yml and formats.md
- Add a rendering test (representative locales + an all-locales seconds guard)
Assisted-By: devx/aa33f4dc-e917-41af-9b6c-83e935289511
SimonSiju
force-pushed
the
simonsiju/date-at-time-with-seconds-format
branch
from
September 14, 2026 18:49
e7456b5 to
b22a997
Compare
SimonSiju
changed the title
:date_at_time_with_seconds date/time format:date_time_current_year_with_seconds date/time format
SimonSiju
marked this pull request as ready for review
September 14, 2026 18:50
najibna
reviewed
Sep 21, 2026
najibna
left a comment
najibna
left a comment
There was a problem hiding this comment.
Reusing date_time_current_year with time.medium is the right approach, and the all-locales %S assertion is a good guard.
Nit: the changelog entry is longer than the rest of this file. The first sentence is enough.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
:date_time_current_year_with_seconds—:date_time_current_year(a compact, year-omitted "MMM d + time" timestamp) with the time upgraded to second precision.It exists for cross-system log/event correlation, where the exact second matters. Like the base format, each locale owns the field order, separators, and 12h/24h clock — nothing is forced:
Dec 26, 1:23:45 pm(12-hour)26 déc. 13:23:45(24-hour, day-first)13:23:45, 26 Thg 12(time-first)26. dec. 13.23.45(.separators)12月26日 13:23:4512월 26일 오후 1:23:45How
DATETIME_FORMAT_MAP: the locale'sdatetime.shortcombiner +MMMd+time.medium(the seconds-bearing, locale-clock time format).data/other/generated/*.yml(805 locales) +formats.md— reproducible via the CLDR rake task (bin/test-cldr-rake-tasksre-runs it and fails on any diff).Notes (review feedback addressed)
date_time_current_year+ seconds, notdate_at_time+ seconds; the name reflects that so it doesn't need a breaking rename later.time.medium) rather than forcing 24h everywhere.date_time_current_year. The consuming surface (Dev Dashboard app-logs) shows recent logs and pins the exact instant via its local + UTC hover tooltip.data/other/generated/is generated.Consuming change: Dev Dashboard app-logs timestamps (shop/issues-develop#23821).