Stop duplicate CI runs and surface test runner errors - #808
Merged
Merged
Conversation
CI runs on both `push` and `pull_request`, so every in-repo branch (including Dependabot's) gets two identical runs. On PR #807 the two runs for 43a9411 started three seconds apart: the push run downloaded VS Code 1.137.0 and passed, while the pull_request run died 290ms into "Resolving version..." — the duplicates race each other for the same VS Code download and can get throttled. Limit `push` to main so branch pushes are covered once by the pull_request event, and add a concurrency group so superseded PR runs are cancelled. Post-merge runs on main are not cancelled, so every merged commit keeps its own signal. That failure was also undiagnosable: the catch block in runTest.ts logged "Failed to run tests" and discarded the error, so the log named no cause. Pass the error to console.error. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Assisted-By: devx/a4b3b2ac-0c11-4784-be17-3f07cf65256b
vinistock
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's broken
PR #807 had a failing
buildcheck that had nothing to do with its dependency bumps. The workflow triggers onon: [push, pull_request], so every in-repo branch (including every Dependabot branch) gets two identical runs. For commit43a9411, the two runs started three seconds apart:pushpull_requestResolving version...Same commit, same workflow, opposite results. The duplicate jobs race each other for the same VS Code download and can get throttled. Re-running the failed job passed, confirming the flake.
The failure was also undiagnosable.
src/test/runTest.tscaught the error and logged only:because
console.error("Failed to run tests")discardederr.Changes
.github/workflows/ci.yml— limitpushtomain, so branch pushes are covered once by thepull_requestevent. Adds a concurrency group so superseded PR runs get cancelled.cancel-in-progressis conditional onpull_request, so post-merge runs onmainare never cancelled and every merged commit keeps its own signal.src/test/runTest.ts— passerrtoconsole.errorso the cause and stack trace reach the log.Verification
yarn run lintpasses (eslint + prettier, including the reformatted YAML).yarn run testpasses locally.Note this PR does not add retry logic for the VS Code download — removing the self-inflicted duplicate run addresses the observed cause, and a real outage should still fail loudly (and now legibly).
🤖 Generated with Claude Code