Skip to content

Fix close-external-prs workflow incorrectly closing internal PRs #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lizkenyon merged 1 commit into from
Feb 10, 2026
Merged

Fix close-external-prs workflow incorrectly closing internal PRs #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 22 additions & 16 deletions .github/workflows/close-external-prs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,25 +17,31 @@ jobs:
with:
script: |
const author = context.payload.pull_request.user.login;
const association = context.payload.pull_request.author_association;

try {
// Check if the author is a member of the Shopify organization
await github.rest.orgs.checkMembershipForUser({
org: 'Shopify',
username: author
});
// author_association is unreliable when org membership is private
// (returns CONTRIBUTOR instead of MEMBER), so also check the
// repo permission level which works regardless of visibility
const trustedAssociations = ['MEMBER', 'OWNER', 'COLLABORATOR'];
let isTrusted = trustedAssociations.includes(association);

console.log(`${author} is a Shopify member`);
core.setOutput('is-shopify', 'true');
} catch (error) {
if (error && error.status === 404) {
console.log(`${author} is not a Shopify member`);
} else {
console.log(`Error checking Shopify membership for ${author}: ${error}`);
if (!isTrusted) {
try {
const { data } = await github.rest.repos.getCollaboratorPermissionLevel({
owner: context.repo.owner,
repo: context.repo.repo,
username: author,
});
isTrusted = ['write', 'admin'].includes(data.permission);
console.log(`${author} repo permission: ${data.permission}`);
} catch (error) {
console.log(`Permission check failed for ${author}: ${error.message}`);
}
core.setOutput('is-shopify', 'false');
}

console.log(`${author} author_association: ${association}, trusted: ${isTrusted}`);
core.setOutput('is-shopify', isTrusted ? 'true' : 'false');

- name: Close PR and comment
if: steps.check-author.outputs.is-shopify == 'false'
uses: actions/github-script@v7
Expand All @@ -50,11 +56,11 @@ jobs:
issue_number: prNumber,
body: `Thanks for your interest. This repository does not accept contributions, so we've closed this PR.

To report a bug, request a feature, or share feedback, please post in the [Shopify dev community forums](https://community.shopify.dev/c/shopify-cli-libraries/14)
To report a bug, request a feature, or share feedback, please post in the [Shopify dev community forums](https://community.shopify.dev/new-topic?title=[Feedback%20for%20python%20package]&category=shopify-cli-libraries&tags=python-library&domain=Python%20Library)

We triage in the forums, not in this repo. PRs and issues here are closed without review.

For more details see [CONTRIBUTING.md](https://github.com/Shopify/shopify-app-python?tab=contributing-ov-file).`
For more details see [CONTRIBUTING.md](https://github.com/Shopify/shopify-app-python/blob/main/CONTRIBUTING.md).`
});

// Close the PR
Expand Down