Repository navigation
Fix multi-row binlog checkpointing - #60
Merged
Merged
Conversation
Route ordered completion markers through the existing DML queues and persist a separate applied-transaction watermark only after preceding SQL commits. Preserve batching and reject acknowledgements after failed delivery or migration cancellation. Make reader operations and checkpoint SQL cancellation-aware. Cover multi-row events, MySQL/MariaDB GTID cloning, partial-apply replay, failed batches, and cancellation during both checkpoint polling and an in-flight INSERT. Keep go-mysql at v1.15.0; compressed payload support is a separate change.
coding-chimp
changed the base branch from
master
to
sync-upstream-2026-11-22
September 28, 2026 15:54
coding-chimp
changed the base branch from
sync-upstream-2026-11-22
to
master
September 28, 2026 15:54
coding-chimp
added this pull request to stack #62
September 28, 2026 15:54
grodowski
approved these changes
Sep 30, 2026
| Coordinates: coords.Clone(), | ||
| TransactionComplete: true, | ||
| } | ||
| if err := base.SendWithContext(gmr.migrationContext.GetContext(), entriesChannel, marker); err != nil { |
Member
There was a problem hiding this comment.
We're increasing the throughput of entriesChannel. I suspect this shouldn't realistically affect anything, but just pointing out there's an extra BinlogEntry for every transaction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the existing risk of checkpointing a partially applied binlog transaction. Per-row coordinates are progress, not proof that every change sharing those coordinates has reached the ghost table.
Testing
GOTOOLCHAIN=auto go test ./...suite passed.