Add shopify/Discount app intent link snippets for React Router tutorial - #75
Open
loic-d wants to merge 3 commits into
Open
Add shopify/Discount app intent link snippets for React Router tutorial#75loic-d wants to merge 3 commits into
loic-d wants to merge 3 commits into
Conversation
Generated from Shopify/discount-functions-testing#1408. Adds the coderef sources for the new 'Let Sidekick create and edit your discount' step in the build-ui-with-react-router tutorial: - docs/reference/shopify/{javascript,rust}/shopify.extension.toml: create + edit admin.app.intent.link extensions under the discount-function.app-intent-link tag - docs/reference/shopify/{javascript,rust}/create-intent-schema.json, edit-intent-schema.json, instructions.md Scoped to just these files; unrelated regen drift (formatting/deps) omitted. Assisted-By: devx/544990ff-9f89-4bd0-8c23-777a2f097188
The {id} URL segment is filled with the discount's ID at runtime; only
the Function ID stays hardcoded. Keeps the comment implementation-agnostic.
Synced from discount-functions-testing.
lauramann
reviewed
Jul 27, 2026
The functionId property only needs matchValue for intent disambiguation. Drop the JSON-Schema type and description so the snippet matches the shape we actually ship. Synced from discount-functions-testing.
lauramann
reviewed
Jul 27, 2026
| "$ref": "https://extensions.shopifycdn.com/shopifycloud/schemas/v1/shopify/discount.json", | ||
| "additionalProperties": true, | ||
| "properties": { | ||
| "functionId": { |
There was a problem hiding this comment.
should we still include mapTo: param here? like in DFT
There was a problem hiding this comment.
nvm I see this PR now: https://github.com/Shopify/discount-functions-testing/pull/1429
lauramann
approved these changes
Jul 27, 2026
lauramann
left a comment
lauramann
left a comment
There was a problem hiding this comment.
LGTM - just a question around whether we should still include mapTo on the intent-schema
iphipps
reviewed
Jul 29, 2026
|
|
||
| [[extensions.targeting]] | ||
| target = "admin.app.intent.link" | ||
| # {id} receives the discount ID; the Function ID stays hardcoded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the coderef source snippets for the new "Let Sidekick create and edit your discount" step in the
build-ui-with-react-routertutorial. Generated from Shopify/discount-functions-testing#1408 (dev generate-reference-app), scoped to only the app-intent-link files.Files
docs/reference/shopify/{javascript,rust}/shopify.extension.toml— create + editadmin.app.intent.linkextensions under thediscount-function.app-intent-linktag (added to the existing React Router function toml)docs/reference/shopify/{javascript,rust}/create-intent-schema.json,edit-intent-schema.json,instructions.mdDetails
YOUR_FUNCTION_ID; edit URL is/app/discount/YOUR_FUNCTION_ID/{id}(matches the app'sapp.discount.$functionId.$idroute)functionIdusesmatchValue; notools.jsonRelated
Note on scope
This is a curated diff. A full
dev generate-reference-appalso rewrites ~110 unrelated files (oxfmt reflow, dependency/lockfile churn, new.oxfmtrc.json/.oxlintrc.json) becausemainis stale vs currentdiscount-functions-testingmain. That drift is intentionally omitted here and should be handled as a separate maintenance regen.