Add typed JSON output for store create dev - #8584
Merged
gonzaloriestra merged 2 commits intoSep 21, 2026
Merged
Conversation
gonzaloriestra
added this pull request to stack #8564
September 18, 2026 11:45
gonzaloriestra
commented
Sep 18, 2026
Contributor
Author
There was a problem hiding this comment.
Moved from packages/store/src/cli/services/store/types.ts to be able to share it
gonzaloriestra
marked this pull request as ready for review
September 18, 2026 14:34
dmerand
approved these changes
Sep 21, 2026
gonzaloriestra
force-pushed
the
gonzalo/json-store-create-dev
branch
from
September 21, 2026 16:49
9d6d1c2 to
65ebbfc
Compare
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/local-storage.d.ts@@ -48,7 +48,6 @@ export declare class LocalStorage<T extends Record<string, any>> {
*
* @param error - The error that occurred.
* @param operation - The operation that failed.
- * @param configPath - The local storage configuration file path.
* @throws AbortError if the error is permission-related.
* @throws BugError if the error is not permission-related.
*/
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The dev-store creation command supports JSON but does not expose or validate its output contract.
WHAT is this pull request doing?
Adds a discoverable schema for creation results and existing JSON errors. Reuses store and organization schemas from
@shopify/organizations, which also servesapp dev, and derives accepted plans from the existing plan definitions. Preserves text output and the creation service’s domain return value.Example output
Illustrative sample data. Text excerpts omit terminal decoration and progress. JSON blocks show the final stdout result; progress and diagnostics go to stderr.
shopify store create dev --name "JSON schema test" --organization-id 1234 --plan basic --no-demo-dataText
JSON (
--json){ "store": { "name": "JSON schema test", "domain": "json-schema-test.myshopify.com", "adminUrl": "https://admin.shopify.com/store/json-schema-test", "plan": "basic", "demoData": false }, "organization": { "id": "1234", "name": "Acme" } }How to manually test your changes?
Checklist