Update rushstack packages. - #269
Merged
Ian Clanton-Thuon (iclanton) merged 3 commits intoSep 30, 2026
Merged
Conversation
Ian Clanton-Thuon (iclanton)
enabled auto-merge (squash)
September 30, 2026 16:55
Copilot started reviewing on behalf of
Ian Clanton-Thuon (iclanton)
September 30, 2026 16:56
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The broad toolchain upgrade and generated bootstrap changes require successful full CI validation before approval.
Review effort: Balanced
Findings: None
What changed in this PR
Updates the repository’s RushStack toolchain and keeps generated SPFx templates aligned with their examples.
Changes:
- Upgrades Rush, Heft, ESLint, and supporting RushStack packages.
- Refreshes generated Rush bootstrap scripts, registry configuration, and lock state.
- Synchronizes dependency versions across templates and examples.
| File | Description |
|---|---|
tools/spfx-cli-build-rig/package.json |
Updates build-rig dependencies. |
tools/repo-toolbox/package.json |
Updates tooling and webpack dependencies. |
tests/spfx-template-test/package.json |
Updates template-test tooling. |
templates/webpart-react/package.json |
Updates template build tooling. |
templates/webpart-noframework/package.json |
Updates template build tooling. |
templates/webpart-minimal/package.json |
Updates template build tooling. |
templates/library/package.json |
Updates template build tooling. |
templates/extension-search-query-modifier/package.json |
Updates template build tooling. |
templates/extension-listviewcommandset/package.json |
Updates template build tooling. |
templates/extension-formcustomizer-react/package.json |
Updates template build tooling. |
templates/extension-formcustomizer-noframework/package.json |
Updates template build tooling. |
templates/extension-fieldcustomizer-react/package.json |
Updates template build tooling. |
templates/extension-fieldcustomizer-noframework/package.json |
Updates template build tooling. |
templates/extension-fieldcustomizer-minimal/package.json |
Updates template build tooling. |
templates/extension-application-customizer/package.json |
Updates template build tooling. |
templates/copilot-component-react/package.json |
Updates template build tooling. |
templates/copilot-component-noframework/package.json |
Updates template build tooling. |
templates/copilot-component-minimal/package.json |
Updates template build tooling. |
templates/ace-search-card/package.json |
Updates template build tooling. |
templates/ace-generic-primarytext-card/package.json |
Updates template build tooling. |
templates/ace-generic-image-card/package.json |
Updates template build tooling. |
templates/ace-generic-card/package.json |
Updates template build tooling. |
templates/ace-data-visualization/package.json |
Updates template build tooling. |
rush.json |
Upgrades Rush to 5.180.0. |
examples/webpart-react/package.json |
Synchronizes example dependencies. |
examples/webpart-noframework/package.json |
Synchronizes example dependencies. |
examples/webpart-minimal/package.json |
Synchronizes example dependencies. |
examples/library/package.json |
Synchronizes example dependencies. |
examples/extension-search-query-modifier/package.json |
Synchronizes example dependencies. |
examples/extension-listviewcommandset/package.json |
Synchronizes example dependencies. |
examples/extension-formcustomizer-react/package.json |
Synchronizes example dependencies. |
examples/extension-formcustomizer-noframework/package.json |
Synchronizes example dependencies. |
examples/extension-fieldcustomizer-react/package.json |
Synchronizes example dependencies. |
examples/extension-fieldcustomizer-noframework/package.json |
Synchronizes example dependencies. |
examples/extension-fieldcustomizer-minimal/package.json |
Synchronizes example dependencies. |
examples/extension-application-customizer/package.json |
Synchronizes example dependencies. |
examples/copilot-component-react/package.json |
Synchronizes example dependencies. |
examples/copilot-component-noframework/package.json |
Synchronizes example dependencies. |
examples/copilot-component-minimal/package.json |
Synchronizes example dependencies. |
examples/ace-search-card/package.json |
Synchronizes example dependencies. |
examples/ace-generic-primarytext-card/package.json |
Synchronizes example dependencies. |
examples/ace-generic-image-card/package.json |
Synchronizes example dependencies. |
examples/ace-generic-card/package.json |
Synchronizes example dependencies. |
examples/ace-data-visualization/package.json |
Synchronizes example dependencies. |
common/scripts/install-run.js |
Refreshes generated installation bootstrap logic. |
common/scripts/install-run-rush.js |
Adds generated reporter bootstrap support. |
common/config/rush/repo-state.json |
Refreshes generated repository hashes. |
common/config/rush/common-versions.json |
Updates the preferred Heft version. |
common/config/rush/.npmrc |
Configures Microsoft’s package-feed proxy. |
common/changes/@microsoft/spfx-cli/iclanton-node-26-support_2026-09-30-16-06-03.json |
Adds the required change record. |
common/autoinstallers/plugins/pnpm-lock.yaml |
Refreshes autoinstaller resolutions. |
common/autoinstallers/plugins/package.json |
Updates the Rush plugin dependency. |
apps/spfx-cli/package.json |
Updates CLI RushStack dependencies. |
api/spfx-template-api/package.json |
Updates API RushStack dependencies. |
Files not reviewed (3)
- common/autoinstallers/plugins/pnpm-lock.yaml: Generated file
- common/scripts/install-run-rush.js: Generated file
- common/scripts/install-run.js: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Copilot started reviewing on behalf of
Ian Clanton-Thuon (iclanton)
September 30, 2026 17:01
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The generated Rush bootstrap embeds version 5.179.0 despite selecting Rush 5.180.0, invalidating its compatibility check.
Review effort: Balanced
Findings: 1
Files not reviewed (3)
- common/autoinstallers/plugins/pnpm-lock.yaml: Generated file
- common/scripts/install-run-rush.js: Generated file
- common/scripts/install-run.js: Generated file
Copilot started reviewing on behalf of
Ian Clanton-Thuon (iclanton)
September 30, 2026 17:06
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The generated bootstrap and registry changes warrant final human and CI validation.
Review effort: Balanced
Findings: 1
Files not reviewed (3)
- common/autoinstallers/plugins/pnpm-lock.yaml: Generated file
- common/scripts/install-run-rush.js: Generated file
- common/scripts/install-run.js: Generated file
Previously missed (1)
In code that hasn't changed since last review
tools/repo-toolbox/package.json:28
Keep the devDependencies block alphabetized: the new tslib entry follows webpack, and the updated Heft entries are also reversed. Other changed manifests keep dependency keys sorted (for example, tools/spfx-cli-build-rig/package.json:24-36), so sorting this block avoids churn in future dependency updates.
shawndubeMSFT
approved these changes
Sep 30, 2026
Ian Clanton-Thuon (iclanton)
merged commit Sep 30, 2026
81de634
into
SharePoint:main
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.