Repository navigation
Conversation
- AI prompts: valid edge handle ids, <=/>= operators, knowledge question count, Write-Error semantics, workflow generation output envelope - docs/testing/e2e/71-80.md: complete restart/hot-reload section lists - release-lab README: computer-use catalog case count - tech-demo READMEs: node and activity-type counts, runScript capture scope - scripts/README.md: master covers 27 of 29 activities - stress-test README: process engine for engine:auto, per-pass workloads - ad-sso-labtest README: account and group names created by the setup script Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DsPJNb4ajYfcjeHyvMyoG5
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Weekly documentation audit for 2026-10-25, run against
origin/main4f83f89. Week index 2964, documentation block 4 of 0–7 (44 files:grafana/README.mdthroughsrc/NodePilot.Ai/Prompts/*.md), code slice 0 (activities, execution, triggers, scheduling). Every edit below is a documentation correction proven by the code. No code, tests or config were changed.How (corrections and evidence)
AI prompts (
src/NodePilot.Ai/Prompts/). These are sent to the LLM, so drift here changes runtime behaviour.workflow-system.md: the prompt told the model to reply with a bare{nodes, edges}object and "no other top-level keys".WorkflowGenerationService.GenerateAsyncappends an output envelope{name, description, definition}to this same prompt, andParseEnvelopethrows "Envelope is missing 'definition' object" for the bare shape. The rule now points at the envelope.activity-reference.md: the edge example usedsourceHandle: "out"/targetHandle: "in". Those are not valid ports.lib/edgePorts.tsaccepts only top/right/bottom/left, with defaults right→left, and normalizes anything else. The example now usesright/left.activity-reference.md: added the missing<=and>=operators (EdgeConditionValidator.cs:18,ConditionEvaluator.cs:53,155-156).knowledge-system.md: "three kinds of questions" → "five". The list below it has five groups, andKnowledgeChatToolRegistryregisters five gated tool groups.script-system.md:Write-Errordoes not set a non-zero exit code. Step success is based on errors, and the exit code comes only from$LASTEXITCODE(RunScriptActivity.cs:68,167; runScript promptNotes).Other docs
docs/testing/e2e/71-80.md: the restart and hot-reload section lists were incomplete. Added Agents and Performance (restart) and AiKnowledge and WaitForCondition (hot-reload), perSettingsSchema.cs. That gives 13 + 10, which matches CLAUDE.md.scripts/release-lab/README.md: 164 → 167 computer-use cases (computer-use/test_gate.py:23, computer-use README).scripts/tech-demo/README.md:main.jsonhas 39 nodes, not 37.folderOperation.PowerShellScriptWrapper.cs,PowerShellReservedVariables).scripts/tech-demo/xl.README.md:xl.jsoncovers 26 types (20 activities + 6 triggers), not 25/19.scripts/README.md: the master workflow covers 27 of the 29 activities. It does not cover aiAgent or aiAgentTeam; the catalog has 29 peractivity-config-reference.json.scripts/stress-test/README.md:engine: autoruns as a Windows PowerShell 5.1 process, not as in-process runspaces (PowerShellEngineFactory.GetEngine).main.json: √-sum 5·10⁶, SHA in blocks of 50 000, 25 000 regex lines, 200×200 matrix.scripts/ad-sso-labtest/README.md: the test-directory table and its cross-references now use the namesSetup-LabDirectory.ps1creates:svc-nptest-dir,nptest.*,NPTest-Access/NPTest-Admins. The README's own results table already used these names.Testing
dotnet testwas run. The relevant guards,PromptCatalogTestsandDocumentationCountsTests, are left to CI.PromptCatalogTestsassertions ("nodes", "runScript", "Output rules", "PowerShell") are still satisfied by the edited prompts. I checked this by reading the test, not by running it.DocumentationCountsTests.Related issues (category B, not auto-fixed)
#642, #643, #644, #645, #646, #647
Generated by Claude Code