Repository navigation
fix: validate runtime settings before atomic replacement - #636
Merged
Merged
Conversation
Match configuration keys case-insensitively and merge disjoint case-variant sections when reading runtime overrides. Validate serialized candidates with the production JSON configuration parser before changing the original or backups. Add regression tests for mixed casing and duplicate flattened keys. Fixes #611
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Match configuration keys case-insensitively and merge disjoint case-variant sections when reading runtime overrides.
Validate serialized candidates with the production JSON configuration parser before changing the original or backups. Add regression tests for mixed casing and duplicate flattened keys.
Fixes #611
Testing
Api.Tests:
FullyQualifiedName~RuntimeOverrides|FullyQualifiedName~EncryptingJsonConfigurationProviderTests|FullyQualifiedName~AdminSettingsControllerSectionTests|FullyQualifiedName~AdminSettingsRemainingSectionsTests|FullyQualifiedName~Backup— 260 passed. Regressions verify case-insensitive saves, merged disjoint sections, and rejection without changing the original or backups.git diff --checkpassed. Full CI runs on this PR.